Page MenuHomePhabricator

[PDB] Fix `SymbolFilePDBTests` after r345313
ClosedPublic

Authored by aleksandr.urakov on Oct 26 2018, 2:11 AM.

Diff Detail

Repository
rLLDB LLDB

Event Timeline

Ahh, I meant to remind you, because I noticed this when I was looking
through the SymbolFilePDB code recently. I think the LLVM guideline is not
to use so much auto. The generally accepted rule is that we can use for
the result of make_shared, make_unique, and result of iterator types, but
otherwise we prefer to explicitly spell the types out. You don't have to
go and submit another patch on top of this one to fix it again, it's just
something to keep in mind.

That said, thanks for fixing this for me. Sorry for the break.

Ok, thanks! I didn't know about such rule. I'll reduce usages of auto :)

As for such an obvious changes, is it ok to commit them without a review? Or is it still preferable to create reviews for them?

For trivial changes it's ok to submit without review. This is true for
cleanup and trivial refactor, but especially for build break like this
one., and even more so if you consider yourself code owner in the
corresponding code area.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 26 2018, 2:39 AM
This revision was automatically updated to reflect the committed changes.