This is an archive of the discontinued LLVM Phabricator instance.

Differential D53698

[X86] Fix llc invocation on MIR test case
ClosedPublic

Authored by thegameg on Oct 25 2018, 6:44 AM.

Details

Reviewers
thanm
Commits
rG7d55dd673bf5: [X86] Fix llc invocation on MIR test case
rL345266: [X86] Fix llc invocation on MIR test case
Summary

The current state of the llc invocation is:

  • Running all the passes from dwarfehprepare to stack coloring (included)
  • It runs it from the LLVM IR included in the file
  • It *ADDS* the generated MI from ISel to the MI in the MIR file
  • The machine verifier doesn't like it.

Diff Detail

Repository
rL LLVM

Event Timeline

thegameg created this revision.Oct 25 2018, 6:44 AM
Herald added subscribers: JDevlieghere, aprantl. · View Herald TranscriptOct 25 2018, 6:44 AM
thegameg mentioned this in D47372: StackColoring: better handling of statically unreachable code.Oct 25 2018, 6:45 AM
thanm added a comment.Oct 25 2018, 7:02 AM

LGTM. I ran the new recipe in the debugger and it is indeed exercising the PR37130 fix code correctly (lifetime marker set is different, but that doesn't matter in this case).

Thanks for the cleanup.

This revision was not accepted when it landed; it landed in state Needs Review.Oct 25 2018, 7:13 AM
Closed by commit rL345266: [X86] Fix llc invocation on MIR test case (authored by thegameg). · Explain Why
This revision was automatically updated to reflect the committed changes.
thegameg added a comment.Oct 25 2018, 7:13 AM

Thanks!

Revision Contents

PathSize
llvm/
trunk/
test/
CodeGen/
X86/
2 lines

Diff 171086

llvm/trunk/test/CodeGen/X86/PR37310.mir

# RUN: llc -mtriple=x86_64-unknown-linux-gnu -mcpu=corei7 -start-before dwarfehprepare -no-stack-coloring=false -stop-after stack-coloring -o - %s # RUN: llc -mtriple=x86_64-unknown-linux-gnu -mcpu=corei7 -no-stack-coloring=false -run-pass stack-coloring -o - %s
# Test to insure that the liveness analysis in the StackColoring # Test to insure that the liveness analysis in the StackColoring
# pass gracefully handles statically unreachable blocks. See PR 37310. # pass gracefully handles statically unreachable blocks. See PR 37310.
# This MIR testcase was created by compiling the following test, first # This MIR testcase was created by compiling the following test, first
# with "clang -emit-llvm -S" and then "llc -stop-before stack-coloring", # with "clang -emit-llvm -S" and then "llc -stop-before stack-coloring",
# and finally editing the resulting MIR by hand to introduce a statically # and finally editing the resulting MIR by hand to introduce a statically
# unreachable BB (to wit: rename all bb.3 to bb.4, rename bb.2 to bb.3, # unreachable BB (to wit: rename all bb.3 to bb.4, rename bb.2 to bb.3,
▲ Show 20 Lines • Show All 144 Lines • Show Last 20 Lines