This is an archive of the discontinued LLVM Phabricator instance.

[AST] Check that GNU range case statements are correctly imported.
ClosedPublic

Authored by riccibruno on Oct 23 2018, 1:49 PM.

Download Raw Diff

Details

Reviewers

Commits

rG635d49e1dffe: [AST] Check that GNU range case statements are correctly imported.
rL345506: [AST] Check that GNU range case statements are correctly imported.
rC345506: [AST] Check that GNU range case statements are correctly imported.

Summary

The test for case statements did not cover GNU range case statements.

Diff Detail

Repository: rC Clang

Event Timeline

riccibruno created this revision.Oct 23 2018, 1:49 PM

Herald added a subscriber: cfe-commits. · View Herald TranscriptOct 23 2018, 1:49 PM

riccibruno added a parent revision: D53609: [AST] Don't store data for GNU range case statement if not needed..Oct 23 2018, 1:49 PM

LGTM.

This revision is now accepted and ready to land.Oct 24 2018, 5:23 PM

rebased

riccibruno added a child revision: D53714: [AST] Only store the needed data in SwitchStmt..Oct 25 2018, 10:04 AM

Closed by commit rC345506: [AST] Check that GNU range case statements are correctly imported. (authored by brunoricci). · Explain WhyOct 29 2018, 8:06 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

test/

Import/

switch-stmt/

Inputs/

F.cpp

5 lines

test.cpp

11 lines

Diff 171125

test/Import/switch-stmt/Inputs/F.cpp

	void f() {			void f() {
	switch (1) {			switch (1) {
	case 1:			case 1:
	case 2:			case 2:
	break;			break;
				case 3 ... 4:
				case 5 ... 5:
				break;
	}			}
	switch (int varname; 1) {			switch (int varname; 1) {
	case 1:			case 1:
	break;			break;
	case 2:			case 2:
	break;			break;
				case 3 ... 5:
				break;
	}			}
	switch (1)			switch (1)
	default:			default:
	break;			break;
	switch (0)			switch (0)
	;			;
	}			}

test/Import/switch-stmt/test.cpp

	// RUN: clang-import-test -dump-ast -import %S/Inputs/F.cpp -expression %s \| FileCheck %s			// RUN: clang-import-test -dump-ast -import %S/Inputs/F.cpp -expression %s \| FileCheck %s

	// CHECK: SwitchStmt			// CHECK: SwitchStmt
	// CHECK-NEXT: <<NULL>>			// CHECK-NEXT: <<NULL>>
	// CHECK-NEXT: <<NULL>>			// CHECK-NEXT: <<NULL>>
	// CHECK-NEXT: IntegerLiteral			// CHECK-NEXT: IntegerLiteral
	// CHECK-NEXT: CompoundStmt			// CHECK-NEXT: CompoundStmt
	// CHECK-NEXT: CaseStmt			// CHECK-NEXT: CaseStmt
	// CHECK-NEXT: IntegerLiteral			// CHECK-NEXT: IntegerLiteral
	// CHECK-NEXT: CaseStmt			// CHECK-NEXT: CaseStmt
	// CHECK-NEXT: IntegerLiteral			// CHECK-NEXT: IntegerLiteral
	// CHECK-NEXT: BreakStmt			// CHECK-NEXT: BreakStmt
				// CHECK-NEXT: CaseStmt
				// CHECK-NEXT: IntegerLiteral
				// CHECK-NEXT: IntegerLiteral
				// CHECK-NEXT: CaseStmt
				// CHECK-NEXT: IntegerLiteral
				// CHECK-NEXT: IntegerLiteral
				// CHECK-NEXT: BreakStmt

	// CHECK: SwitchStmt			// CHECK: SwitchStmt
	// CHECK-NEXT: DeclStmt			// CHECK-NEXT: DeclStmt
	// CHECK-NEXT: VarDecl			// CHECK-NEXT: VarDecl
	// CHECK-SAME: varname			// CHECK-SAME: varname
	// CHECK-NEXT: <<NULL>>			// CHECK-NEXT: <<NULL>>
	// CHECK-NEXT: IntegerLiteral			// CHECK-NEXT: IntegerLiteral
	// CHECK-NEXT: CompoundStmt			// CHECK-NEXT: CompoundStmt
	// CHECK-NEXT: CaseStmt			// CHECK-NEXT: CaseStmt
	// CHECK-NEXT: IntegerLiteral			// CHECK-NEXT: IntegerLiteral
	// CHECK-NEXT: BreakStmt			// CHECK-NEXT: BreakStmt
	// CHECK-NEXT: CaseStmt			// CHECK-NEXT: CaseStmt
	// CHECK-NEXT: IntegerLiteral			// CHECK-NEXT: IntegerLiteral
	// CHECK-NEXT: BreakStmt			// CHECK-NEXT: BreakStmt
				// CHECK-NEXT: CaseStmt
				// CHECK-NEXT: IntegerLiteral
				// CHECK-NEXT: IntegerLiteral
				// CHECK-NEXT: BreakStmt

	// CHECK: SwitchStmt			// CHECK: SwitchStmt
	// CHECK-NEXT: <<NULL>>			// CHECK-NEXT: <<NULL>>
	// CHECK-NEXT: <<NULL>>			// CHECK-NEXT: <<NULL>>
	// CHECK-NEXT: IntegerLiteral			// CHECK-NEXT: IntegerLiteral
	// CHECK-NEXT: DefaultStmt			// CHECK-NEXT: DefaultStmt
	// CHECK-NEXT: BreakStmt			// CHECK-NEXT: BreakStmt

	Show All 9 Lines