[Fixed Point Arithmetic] Fix for clang-tools-extra warning

[leonardchan]

Summary

Fix for warnings generated on unhandled enum value STK_FixedPoint.

[bjope]

Just some inline nit:s about whitespace.

LGTM, apart from that!

clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp

63 ↗

(On Diff #169739)

nit: I'd add an extra line break before this line (just to follow the earlier style where it seems like cases are put in different groups in this switch).

65 ↗

(On Diff #169739)

Indents: I think case should be aligned with the switch.

clang-tidy/modernize/UseDefaultMemberInitCheck.cpp

case Type::STK_Floating:
     default:
       return "0.0";
     }
 
   case Type::STK_FloatingComplex:
   case Type::STK_IntegralComplex:
     return getValueOfValueInit(
         InitType->getAs<ComplexType>()->getElementType());
+
   case Type::STK_FixedPoint:
     switch (InitType->getAs<BuiltinType>()->getKind()) {
-      case BuiltinType::ShortAccum:
-      case BuiltinType::SatShortAccum:
-        return "0.0hk";
-      case BuiltinType::Accum:
-      case BuiltinType::SatAccum:
-        return "0.0k";
-      case BuiltinType::LongAccum:
-      case BuiltinType::SatLongAccum:
-        return "0.0lk";
-      case BuiltinType::UShortAccum:
-      case BuiltinType::SatUShortAccum:
-        return "0.0uhk";
-      case BuiltinType::UAccum:
-      case BuiltinType::SatUAccum:
-        return "0.0uk";
-      case BuiltinType::ULongAccum:
-      case BuiltinType::SatULongAccum:
-        return "0.0ulk";
-      case BuiltinType::ShortFract:
-      case BuiltinType::SatShortFract:
-        return "0.0hr";
-      case BuiltinType::Fract:
-      case BuiltinType::SatFract:
-        return "0.0r";
-      case BuiltinType::LongFract:
-      case BuiltinType::SatLongFract:
-        return "0.0lr";
-      case BuiltinType::UShortFract:
-      case BuiltinType::SatUShortFract:
-        return "0.0uhr";
-      case BuiltinType::UFract:
-      case BuiltinType::SatUFract:
-        return "0.0ur";
-      case BuiltinType::ULongFract:
-      case BuiltinType::SatULongFract:
-        return "0.0ulr";
-      default:
-        llvm_unreachable("Unhandled fixed point BuiltinType");
     }
   }
   llvm_unreachable("Invalid scalar type kind");
 }
 
 static bool isZero(const Expr *E) {
   switch (E->getStmtClass()) {
   case Stmt::CXXNullPtrLiteralExprClass: