Page MenuHomePhabricator

[Fixed Point Arithmetic] Fix for clang-tools-extra warning
ClosedPublic

Authored by leonardchan on Oct 15 2018, 12:26 PM.

Diff Detail

Event Timeline

leonardchan created this revision.Oct 15 2018, 12:26 PM
leonardchan retitled this revision from [Fixed Point Arithmetic] to [Fixed Point Arithmetic] Fix for clang-tools-extra warning.Oct 15 2018, 12:32 PM
bjope accepted this revision.Oct 15 2018, 12:40 PM

Just some inline nit:s about whitespace.

LGTM, apart from that!

clang-tools-extra/clang-tidy/modernize/UseDefaultMemberInitCheck.cpp
63 ↗(On Diff #169739)

nit: I'd add an extra line break before this line (just to follow the earlier style where it seems like cases are put in different groups in this switch).

65 ↗(On Diff #169739)

Indents: I think case should be aligned with the switch.

This revision is now accepted and ready to land.Oct 15 2018, 12:40 PM
leonardchan marked 2 inline comments as done.
This revision was automatically updated to reflect the committed changes.