This is an archive of the discontinued LLVM Phabricator instance.

Differential D53169

Make YAML serializer quote forward slashes
ClosedPublic

Authored by zturner on Oct 11 2018, 2:00 PM.

Details

Reviewers
rnk
Commits
rG9f169afab22b: Make YAML quote forward slashes.
rL344359: Make YAML quote forward slashes.
rC344359: Make YAML quote forward slashes.
rLLD344359: Make YAML quote forward slashes.
Summary

If you have the string /usr/bin our YAML serializer will not quote this, but if you have the string C:\foo\bar it will quote it.

While technically not required by the YAML standard, it's nice if we're consistent on quoting them since / and \ both commonly appear in paths. Otherwise, the same YAML value may be quoted or unquoted depending on what platform a test is run on. This makes for confusing FileCheck statements.

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

zturner created this revision.Oct 11 2018, 2:00 PM
Herald added subscribers: JDevlieghere, eraman. · View Herald TranscriptOct 11 2018, 2:00 PM
rnk accepted this revision.Oct 11 2018, 3:53 PM

lgtm

Windows paths aside, this is a good change if someone checks out the project inside a directory with spaces, such as "/home/FirstName LastName".

This revision is now accepted and ready to land.Oct 11 2018, 3:53 PM
Closed by commit rLLD344359: Make YAML quote forward slashes. (authored by zturner). · Explain WhyOct 12 2018, 9:33 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

Diff 169431

test/mach-o/cstring-sections.yaml

Show All 30 Lines
... ...
# CHECK: defined-atoms: # CHECK: defined-atoms:
# CHECK: - scope: hidden # CHECK: - scope: hidden
# CHECK: type: c-string # CHECK: type: c-string
# CHECK: content: [ 61, 62, 63, 00 ] # CHECK: content: [ 61, 62, 63, 00 ]
# CHECK: merge: by-content # CHECK: merge: by-content
# CHECK: section-choice: custom-required # CHECK: section-choice: custom-required
# CHECK: section-name: __TEXT/__objc_methname # CHECK: section-name: '__TEXT/__objc_methname'
# CHECK: - scope: hidden # CHECK: - scope: hidden
# CHECK: type: c-string # CHECK: type: c-string
# CHECK: content: [ 64, 65, 66, 00 ] # CHECK: content: [ 64, 65, 66, 00 ]
# CHECK: merge: by-content # CHECK: merge: by-content
# CHECK: section-choice: custom-required # CHECK: section-choice: custom-required
# CHECK: section-name: __TEXT/__objc_methname # CHECK: section-name: '__TEXT/__objc_methname'
# CHECK: - scope: hidden # CHECK: - scope: hidden
# CHECK: type: c-string # CHECK: type: c-string
# CHECK: content: [ 61, 62, 63, 00 ] # CHECK: content: [ 61, 62, 63, 00 ]
# CHECK: merge: by-content # CHECK: merge: by-content
# CHECK: section-choice: custom-required # CHECK: section-choice: custom-required
# CHECK: section-name: __TEXT/__objc_classname # CHECK: section-name: '__TEXT/__objc_classname'
# CHECK: - scope: hidden # CHECK: - scope: hidden
# CHECK: type: c-string # CHECK: type: c-string
# CHECK: content: [ 67, 68, 69, 00 ] # CHECK: content: [ 67, 68, 69, 00 ]
# CHECK: merge: by-content # CHECK: merge: by-content
# CHECK: section-choice: custom-required # CHECK: section-choice: custom-required
# CHECK: section-name: __TEXT/__objc_classname # CHECK: section-name: '__TEXT/__objc_classname'
# CHECK: - scope: hidden # CHECK: - scope: hidden
# CHECK: type: c-string # CHECK: type: c-string
# CHECK: content: [ 61, 62, 63, 00 ] # CHECK: content: [ 61, 62, 63, 00 ]
# CHECK: merge: by-content # CHECK: merge: by-content
# CHECK: - scope: hidden # CHECK: - scope: hidden
# CHECK: type: c-string # CHECK: type: c-string
# CHECK: content: [ 6A, 6B, 6C, 00 ] # CHECK: content: [ 6A, 6B, 6C, 00 ]
# CHECK: merge: by-content # CHECK: merge: by-content

test/mach-o/parse-data-relocs-x86_64.yaml

Show First 20 Lines • Show All 361 Lines • ▼ Show 20 Lines
# CHECK: dead-strip: never # CHECK: dead-strip: never
# CHECK: - name: _bar # CHECK: - name: _bar
# CHECK: content: [ C3 ] # CHECK: content: [ C3 ]
# CHECK: dead-strip: never # CHECK: dead-strip: never
# CHECK: - ref-name: L003 # CHECK: - ref-name: L003
# CHECK: type: unknown # CHECK: type: unknown
# CHECK: content: [ 00, 00, 00, 00, 00, 00, 00, 00 ] # CHECK: content: [ 00, 00, 00, 00, 00, 00, 00, 00 ]
# CHECK: section-choice: custom-required # CHECK: section-choice: custom-required
# CHECK: section-name: __DATA/__custom # CHECK: section-name: '__DATA/__custom'
# CHECK: dead-strip: never # CHECK: dead-strip: never

test/mach-o/parse-data.yaml

Show First 20 Lines • Show All 109 Lines • ▼ Show 20 Lines
# CHECK: type: zero-fill # CHECK: type: zero-fill
# CHECK: size: 4 # CHECK: size: 4
# CHECK: - name: _kustom # CHECK: - name: _kustom
# CHECK: scope: global # CHECK: scope: global
# CHECK: type: unknown # CHECK: type: unknown
# CHECK: content: [ 01, 02, 03, 04, 05, 06, 07, 08 ] # CHECK: content: [ 01, 02, 03, 04, 05, 06, 07, 08 ]
# CHECK: section-choice: custom-required # CHECK: section-choice: custom-required
# CHECK: section-name: __CUST/__custom # CHECK: section-name: '__CUST/__custom'

test/mach-o/sectcreate.yaml

# RUN: ld64.lld -r -arch x86_64 -o %t -sectcreate __DATA __data \ # RUN: ld64.lld -r -arch x86_64 -o %t -sectcreate __DATA __data \
# RUN: %p/Inputs/hw.raw_bytes -print_atoms | FileCheck %s # RUN: %p/Inputs/hw.raw_bytes -print_atoms | FileCheck %s
# CHECK: --- !native # CHECK: --- !native
# CHECK: path: '<linker-internal>' # CHECK: path: '<linker-internal>'
# CHECK: defined-atoms: # CHECK: defined-atoms:
# CHECK: - scope: global # CHECK: - scope: global
# CHECK: type: sectcreate # CHECK: type: sectcreate
# CHECK: content: [ 68, 65, 6C, 6C, 6F, 0A ] # CHECK: content: [ 68, 65, 6C, 6C, 6F, 0A ]
# CHECK: section-choice: custom-required # CHECK: section-choice: custom-required
# CHECK: section-name: __DATA/__data # CHECK: section-name: '__DATA/__data'
# CHECK: dead-strip: never # CHECK: dead-strip: never