[WIP] Print Loop* associated with isl_ast_for

[dpeixott]

Summary

First patch to keep Loop* associated with its corresponding
isl_ast_for_node.

[jdoerfert]

Minor comments and questions.

include/polly/CodeGen/IslAst.h

49

Any reason not to use a unordered small set? (Doesn't really matter, I'm just curious)

142

When do we need this specialization? Shouldn't we always handle the general (LoopSet) case?

lib/CodeGen/IslAst.cpp

274

drop the {}

[dpeixott]

include/polly/CodeGen/IslAst.h

49

I initially used an unordered set, but switched to the ordered set to keep the output deterministic. Otherwise, we could print out the loops in a different order depending on their pointer values when iterating through the set.

142

Good point. I will remove it. It was for lazy programmers that didn't want to deal with the reality of multiple loops.

lib/CodeGen/IslAst.cpp

274

Ah, is that what the linter was flagging? I got confused because it was pointing to the top of the file. Will fix it up.

[jdoerfert]

responses

include/polly/CodeGen/IslAst.h

49

I see the merrit of deterministic output here but it might not be needed here, however I do not want to argue against it.

lib/CodeGen/IslAst.cpp

274

It was not (some space in the setvector was), it is just our/llvm coding style for one statement conditionals/loops.

[jdoerfert]

Doesn't seem to be needed anymore.