This is an archive of the discontinued LLVM Phabricator instance.

Python bindings TypeError in reparse method
Needs ReviewPublic

Authored by bdcht on Sep 17 2018, 7:26 AM.
This revision needs review, but all reviewers have resigned.

Details

Reviewers
sylvestre.ledru
Summary

In method 'reparse' of the python bindings (cindex.py), a TypeError is raised when 'unsaved_files_array' is set from name/value arguments when using Python3.
(This is due to Python3 mess with bytes vs unicode str...)
The way this unsaved_files_array is set here is not consistent with similar code in other methods like 'from_source' or 'codeComplete'. This proposed fix just
replicates what is done in from_source/codeComplete to set this ctypes unsaved_files_array.

Diff Detail

Repository
rC Clang

Event Timeline

bdcht created this revision.Sep 17 2018, 7:26 AM
bdcht edited reviewers, added: sylvestre.ledru; removed: Restricted Project.Sep 19 2018, 4:45 AM

changed reviewers.

I am sorry but I am not the right reviewer for that. Sorry!

sylvestre.ledru resigned from this revision.Nov 1 2018, 4:51 AM