Page MenuHomePhabricator

Refactoring std::function formatter to move core functionality into CPPLanguageRuntime
ClosedPublic

Authored by shafik on Sep 10 2018, 4:34 PM.

Details

Summary

Moving the core functionality of std::function formatter into CPPLanguageRuntime in preparation for future changes to allow us to step into the wrapped callable of std::function.

This will prevent code duplication since both functionalities require the same core pieces of information. This refactor also improves the readability of the existing functionality.

Diff Detail

Repository
rL LLVM

Event Timeline

shafik created this revision.Sep 10 2018, 4:34 PM
jingham accepted this revision.Sep 10 2018, 5:16 PM

Since the runtime has to use the results of the introspection that the formatter is based on, it seems appropriate to put it there. This seems like a fine way to do it.

This revision is now accepted and ready to land.Sep 10 2018, 5:16 PM
shafik updated this revision to Diff 164962.Sep 11 2018, 1:21 PM

Removing change that was meant for the next PR

This revision was automatically updated to reflect the committed changes.