Page MenuHomePhabricator

[winasan] Reduce hotpatch prefix check to 8 bytes

Authored by dmajor on Sep 7 2018, 7:14 AM.


Diff Detail

Event Timeline

dmajor created this revision.Sep 7 2018, 7:14 AM
Herald added subscribers: Restricted Project, llvm-commits. · View Herald TranscriptSep 7 2018, 7:14 AM
dmajor added a comment.Sep 7 2018, 8:05 AM

This isn't strictly necessary for anything; I was just debugging something and noticed that a hook fell back to Trampoline rather than Hotpatch because the prefix nop was only 8 bytes.

rnk accepted this revision.Sep 7 2018, 1:53 PM


I see that we've done this before in rL310419. This was originally added in rL275180. It'd be nice to figure out what tools generate this nop so we can enumerate all the patterns, but for now let's just do this.

This revision is now accepted and ready to land.Sep 7 2018, 1:53 PM
This revision was automatically updated to reflect the committed changes.