This is an archive of the discontinued LLVM Phabricator instance.

[IndVars] Set Changed if rewriteFirstIterationLoopExitValues changes IR. PR38863
ClosedPublic

Authored by mkazantsev on Sep 7 2018, 4:29 AM.

Details

Summary

Currently, rewriteFirstIterationLoopExitValues does not set Changed flag even if it makes
changes in the IR. There is no clear evidence that it can cause a crash, but it
looks highly suspicious and likely invalid.

Diff Detail

Repository
rL LLVM

Event Timeline

mkazantsev created this revision.Sep 7 2018, 4:29 AM

The same comment as in D51777, The semantics of the patch itself lgtm.

skatkov accepted this revision.Sep 9 2018, 10:15 PM
This revision is now accepted and ready to land.Sep 9 2018, 10:15 PM
This revision was automatically updated to reflect the committed changes.