[PGO][CHR] Small cleanup.

[hjyamauchi]

Summary

Do away with demangling. It wasn't really necessary.
Declared some local functions to be static.

[davidxl]

lib/Transforms/Instrumentation/ControlHeightReduction.cpp

426 ↗

(On Diff #164245)

Why this change? Is anonymous namespace not enough?

[hjyamauchi]

lib/Transforms/Instrumentation/ControlHeightReduction.cpp

426 ↗

(On Diff #164245)

It may be ok, https://llvm.org/docs/CodingStandards.html#anonymous-namespaces seems to prefer a static function.

[hjyamauchi]

lib/Transforms/Instrumentation/ControlHeightReduction.cpp

426 ↗

(On Diff #164245)

I meant to say "but" after "ok," before "https://llvm.org...." in the above comment.

[davidxl]

lgtm

llvm/trunk/lib/Transforms/Instrumentation/ControlHeightReduction.cpp

 #include "llvm/IR/MDBuilder.h"
 #include "llvm/Support/BranchProbability.h"
 #include "llvm/Support/MemoryBuffer.h"
 #include "llvm/Transforms/Utils.h"
 #include "llvm/Transforms/Utils/BasicBlockUtils.h"
 #include "llvm/Transforms/Utils/Cloning.h"
 #include "llvm/Transforms/Utils/ValueMapper.h"
 
-#if !defined(_MSC_VER)
-#include <cxxabi.h>
-#endif
 #include <set>
 #include <sstream>
 
 using namespace llvm;
 
 #define DEBUG_TYPE "chr"
 
 #define CHR_DEBUG(X) LLVM_DEBUG(X)
struct CHRStats {
   uint64_t NumBranches;       // The original number of conditional branches /
                               // selects
   uint64_t NumBranchesDelta;  // The decrease of the number of conditional
                               // branches / selects in the hot paths due to CHR.
   uint64_t WeightedNumBranchesDelta; // NumBranchesDelta weighted by the profile
                                      // count at the scope entry.
 };
 
-inline raw_ostream LLVM_ATTRIBUTE_UNUSED &operator<<(raw_ostream &OS,
-                                                     const CHRStats &Stats) {
-  Stats.print(OS);
-  return OS;
-}
-
 // RegInfo - some properties of a Region.
 struct RegInfo {
   RegInfo() : R(nullptr), HasBranch(false) {}
   RegInfo(Region *RegionIn) : R(RegionIn), HasBranch(false) {}
   Region *R;
   bool HasBranch;
   SmallVector<SelectInst *, 8> Selects;
 };
#endif
   HoistStopMapTy HoistStopMap;
 
  private:
   CHRScope(SmallVector<RegInfo, 8> &RegInfosIn,
            SmallVector<CHRScope *, 8> &SubsIn)
     : RegInfos(RegInfosIn), Subs(SubsIn), BranchInsertPoint(nullptr) {}
 };
 
-inline raw_ostream &operator<<(raw_ostream &OS, const CHRScope &Scope) {
-  Scope.print(OS);
-  return OS;
-}
-
 class CHR {
  public:
   CHR(Function &Fin, BlockFrequencyInfo &BFIin, DominatorTree &DTin,
       ProfileSummaryInfo &PSIin, RegionInfo &RIin)
       : F(Fin), BFI(BFIin), DT(DTin), PSI(PSIin), RI(RIin) {}
 
   ~CHR() {
     for (CHRScope *Scope : Scopes) {
private:
   // A map from biased selects to their branch bias
   DenseMap<SelectInst *, BranchProbability> SelectBiasMap;
   // All the scopes.
   DenseSet<CHRScope *> Scopes;
 };
 
 } // end anonymous namespace
 
+static inline
+raw_ostream LLVM_ATTRIBUTE_UNUSED &operator<<(raw_ostream &OS,
+                                              const CHRStats &Stats) {
+  Stats.print(OS);
+  return OS;
+}
+
+static inline
+raw_ostream &operator<<(raw_ostream &OS, const CHRScope &Scope) {
+  Scope.print(OS);
+  return OS;
+}
+
 static bool shouldApply(Function &F, ProfileSummaryInfo& PSI) {
   if (ForceCHR)
     return true;
 
   if (!CHRModuleList.empty() || !CHRFunctionList.empty()) {
     if (CHRModules.count(F.getParent()->getName()))
       return true;
-    StringRef Name = F.getName();
-    if (CHRFunctions.count(Name))
-      return true;
-    const char* DemangledName = nullptr;
-#if !defined(_MSC_VER)
-    int Status = -1;
-    DemangledName = abi::__cxa_demangle(Name.str().c_str(),
-                                        nullptr, nullptr, &Status);
-#endif
-    return DemangledName && CHRFunctions.count(DemangledName);
+    return CHRFunctions.count(F.getName());
   }
 
   assert(PSI.hasProfileSummary() && "Empty PSI?");
   return PSI.isFunctionEntryHot(&F);
 }
 
 static void LLVM_ATTRIBUTE_UNUSED dumpIR(Function &F, const char *Label,
                                          CHRStats *Stats) {
-  std::string Name = F.getName().str();
-  const char *DemangledName = nullptr;
-#if !defined(_MSC_VER)
-  int Status = -1;
-  DemangledName = abi::__cxa_demangle(Name.c_str(),
-                                      nullptr, nullptr, &Status);
-#endif
-  if (DemangledName == nullptr) {
-    DemangledName = "<NOT-MANGLED>";
-  }
-  std::string ModuleName = F.getParent()->getName().str();
+  StringRef FuncName = F.getName();
+  StringRef ModuleName = F.getParent()->getName();
   CHR_DEBUG(dbgs() << "CHR IR dump " << Label << " " << ModuleName << " "
-            << Name);
+            << FuncName);
   if (Stats)
     CHR_DEBUG(dbgs() << " " << *Stats);
   CHR_DEBUG(dbgs() << "\n");
   CHR_DEBUG(F.dump());
 }
 
 void CHRScope::print(raw_ostream &OS) const {
   assert(RegInfos.size() > 0 && "Empty CHRScope");