Page MenuHomePhabricator

[libomptarget] Remove `Devices` from `RTLInfoTy`
ClosedPublic

Authored by sdmitriev on Sep 4 2018, 1:00 PM.

Details

Summary

This patch removes RTLInfoTy::Devices to fix a potential problem of using invalid pointers stored in this vector. The problem is described in comments to this patch https://reviews.llvm.org/D51623

Diff Detail

Repository
rL LLVM

Event Timeline

sdmitriev created this revision.Sep 4 2018, 1:00 PM
Hahnfeld accepted this revision.Sep 4 2018, 1:12 PM

LG, but please revise the summary to say that the variable was unused. I think that's enough of motivation, no need to refer to "potential problems" or other patches.

This revision is now accepted and ready to land.Sep 4 2018, 1:12 PM
This revision was automatically updated to reflect the committed changes.