This is an archive of the discontinued LLVM Phabricator instance.

Reuse the SelectorTable from Clang's Preprocessor
ClosedPublic

Authored by teemperor on Aug 23 2018, 2:17 PM.

Details

Summary

At the moment we create our own SelectorTable even though the Preprocessor always
creates one for us that we can (and should) reuse.

Diff Detail

Event Timeline

teemperor created this revision.Aug 23 2018, 2:17 PM
teemperor added a subscriber: lldb-commits.
vsk accepted this revision.Aug 23 2018, 3:24 PM

LGTM. This is NFC, it seems. There's a FIXME in Preprocessor.h about the lifetime of SelectorTable eventually not being tied to Preprocessor, but this is correct for now.

This revision is now accepted and ready to land.Aug 23 2018, 3:24 PM

Yeah, but the FIXME has been around for like a decade, so I think that bug has survived long enough to be promoted to a feature :).

This revision was automatically updated to reflect the committed changes.
teemperor added a project: Restricted Project.Aug 30 2018, 12:45 PM