This is an archive of the discontinued LLVM Phabricator instance.

Paths

[Support][Endian] Overload += and -=
ClosedPublic

Authored by ruiu on Aug 28 2014, 11:48 AM.

Reviewers

majnemer
Bigcheese

Summary

This patch is to overload operator+= and operator-= for {u}{little}{big}{8,16,32,64}_t.

ruiu retitled this revision from to [Support][Endian] Overload += and -=.

ruiu updated this object.

ruiu edited the test plan for this revision. (Show Details)

ruiu added a reviewer: Bigcheese.

ruiu added a subscriber: Unknown Object (MLST).

LGTM with tweaks.

include/llvm/Support/Endian.h
96	Move the `&` next to the `operator` keyword.
101	Ditto.

This revision is now accepted and ready to land.Sep 11 2014, 3:59 PM

Committed in r217637.

Path

Size

include/

llvm/

Support/

10 lines

Show First 20 Lines • Show All 87 Lines • ▼ Show 20 Lines	return endian::read<value_type, endian, alignment>(
(const void*)Value.buffer);		(const void*)Value.buffer);
}		}

void operator=(value_type newValue) {		void operator=(value_type newValue) {
endian::write<value_type, endian, alignment>(		endian::write<value_type, endian, alignment>(
(void*)Value.buffer, newValue);		(void*)Value.buffer, newValue);
}		}

		packed_endian_specific_integral& operator+=(value_type newValue) {
		majnemerUnsubmitted Not Done Reply Inline Actions Move the `&` next to the `operator` keyword. majnemer: Move the `&` next to the `operator` keyword.
		this = this + newValue;
		return *this;
		}

		packed_endian_specific_integral& operator-=(value_type newValue) {
		majnemerUnsubmitted Not Done Reply Inline Actions Ditto. majnemer: Ditto.
		this = this - newValue;
		return *this;
		}

private:		private:
AlignedCharArray<PickAlignment<value_type, alignment>::value,		AlignedCharArray<PickAlignment<value_type, alignment>::value,
sizeof(value_type)> Value;		sizeof(value_type)> Value;

public:		public:
struct ref {		struct ref {
explicit ref(void *Ptr) : Ptr(Ptr) {}		explicit ref(void *Ptr) : Ptr(Ptr) {}

▲ Show 20 Lines • Show All 104 Lines • Show Last 20 Lines