Page MenuHomePhabricator

Automatically set path to sanitizer runtime when running tests on macOS.

Authored by aprantl on Aug 20 2018, 2:37 PM.

Diff Detail

Event Timeline

aprantl created this revision.Aug 20 2018, 2:37 PM
vsk added a comment.Aug 20 2018, 2:44 PM

Thanks so much for doing this!


This might be easier to read as either import commands; commands.getoutput(...) or check_output(..., shell=True).strip(). Then it's possible to drop the [:-1], which is nice, because it's not clear that that strips a trailing newline.


The dash should be an underscore, and lldb hits false positives when the container overflow check is enabled. How about: ASAN_OPTIONS=detect_stack_use_after_return=1:container_overflow=0?

vsk accepted this revision.Aug 20 2018, 2:45 PM

(LGTM with the second comment addressed.)

This revision is now accepted and ready to land.Aug 20 2018, 2:45 PM

Thanks, that was quite helpful!

This revision was automatically updated to reflect the committed changes.