This is an archive of the discontinued LLVM Phabricator instance.

[yaml2obj] - Teach yaml2obj to produce SHT_GROUP section with a custom Info field.
ClosedPublic

Authored by grimar on Aug 15 2018, 6:39 AM.

Details

Summary

It is useful to allow this because we would be able to replace at least one binary
object committed in LLD and replace it with the yaml2obj based test.

Diff Detail

Event Timeline

grimar created this revision.Aug 15 2018, 6:39 AM
jhenderson accepted this revision.Aug 15 2018, 6:48 AM

LGTM, with nit.

test/tools/yaml2obj/elf-comdat-broken2.yaml
1

Maybe worth calling this broken-info rather than broken2, to be more descriptive.

18

Nit: with a custom Info value

This revision is now accepted and ready to land.Aug 15 2018, 6:48 AM
This revision was automatically updated to reflect the committed changes.