Changed error messages to be more informative and to resemble other clang/llvm error messages (first letter is lower case, no ending punctuation) and updated corresponding tests.
Details
Diff Detail
Event Timeline
Thanks for going through these. There's a couple unrelated changes and a couple errors that I think could be better.
lib/Target/Mips/AsmParser/MipsAsmParser.cpp | ||
---|---|---|
2485 | Could you drop this line and change AtRegNo to unsigned in a follow up? | |
2508–2512 | Similarly, can you drop this FIXME and make the change in a follow up | |
2577 | I'm not sure this one is an improvement. Most error messages don't address the user with things like 'you must ...'. | |
3047–3048 | I'm not sure about this one. I agree that we don't need to repeat the context since it's already printed in the location part of the error, but 'unknown option' seems a rather brief. Perhaps "unknown option, expected 'pic0' or 'pic2'"? |
There's a couple unrelated changes ...
Sorry, clicked submit too soon. I mean there's a couple unrelated changes in the patch that should be in a separate patch.
Could you drop this line and change AtRegNo to unsigned in a follow up?