[CGObjCGNU] Rename GetSelector helper method to fix -Woverloaded-virtual warning (PR38210)

[RKSimon]

Summary

As suggested by @theraven on PR38210, this patch fixes the gcc -Woverloaded-virtual warnings by renaming the extra CGObjCGNU::GetSelector method to CGObjCGNU::GetTypedSelector

[xbolva00]

Thanks, this warning is really annoying.

[theraven]

Looks good to me. This method should probably take a StringRef rather than a const std::string&, but I can make that change separately.

cfe/trunk/lib/CodeGen/CGObjCGNU.cpp

for (const auto *I : Methods)
       else
         RequiredMethods.push_back(I);
     Required = GenerateProtocolMethodList(RequiredMethods);
     Optional = GenerateProtocolMethodList(OptionalMethods);
   }
 
   /// Returns a selector with the specified type encoding.  An empty string is
   /// used to return an untyped selector (with the types field set to NULL).
-  virtual llvm::Value *GetSelector(CodeGenFunction &CGF, Selector Sel,
+  virtual llvm::Value *GetTypedSelector(CodeGenFunction &CGF, Selector Sel,
                                         const std::string &TypeEncoding);
 
   /// Returns the name of ivar offset variables.  In the GNUstep v1 ABI, this
   /// contains the class and ivar names, in the v2 ABI this contains the type
   /// encoding as well.
   virtual std::string GetIVarOffsetVariableName(const ObjCInterfaceDecl *ID,
                                                 const ObjCIvarDecl *Ivar) {
     const std::string Name = "__objc_ivar_offset_" + ID->getNameAsString()
       + '.' + Ivar->getNameAsString();
llvm::Constant *GenerateProtocolRef(const ObjCProtocolDecl *PD) {
     Protocol = GV;
     return GV;
   }
   llvm::Constant *EnforceType(llvm::Constant *Val, llvm::Type *Ty) {
     if (Val->getType() == Ty)
       return Val;
     return llvm::ConstantExpr::getBitCast(Val, Ty);
   }
-  llvm::Value *GetSelector(CodeGenFunction &CGF, Selector Sel,
+  llvm::Value *GetTypedSelector(CodeGenFunction &CGF, Selector Sel,
                                 const std::string &TypeEncoding) override {
     return GetConstantSelector(Sel, TypeEncoding);
   }
   llvm::Constant  *GetTypeString(llvm::StringRef TypeEncoding) {
     if (TypeEncoding.empty())
       return NULLPtr;
     std::string MangledTypes = TypeEncoding;
     std::replace(MangledTypes.begin(), MangledTypes.end(),
       '@', '\1');
if (auto *ClassSymbol = dyn_cast<llvm::GlobalVariable>(Value)) {
           break;
 
       CGM.setGVProperties(ClassSymbol, VD);
     }
   }
   return Value;
 }
 
-llvm::Value *CGObjCGNU::GetSelector(CodeGenFunction &CGF, Selector Sel,
+llvm::Value *CGObjCGNU::GetTypedSelector(CodeGenFunction &CGF, Selector Sel,
                                          const std::string &TypeEncoding) {
   SmallVectorImpl<TypedSelector> &Types = SelectorTable[Sel];
   llvm::GlobalAlias *SelValue = nullptr;
 
   for (SmallVectorImpl<TypedSelector>::iterator i = Types.begin(),
       e = Types.end() ; i!=e ; i++) {
     if (i->first == TypeEncoding) {
       SelValue = i->second;
       break;
Address CGObjCGNU::GetAddrOfSelector(CodeGenFunction &CGF, Selector Sel) {
   // GetAddrOfSelector?  Hopefully.
   Address tmp = CGF.CreateTempAlloca(SelValue->getType(),
                                      CGF.getPointerAlign());
   CGF.Builder.CreateStore(SelValue, tmp);
   return tmp;
 }
 
 llvm::Value *CGObjCGNU::GetSelector(CodeGenFunction &CGF, Selector Sel) {
-  return GetSelector(CGF, Sel, std::string());
+  return GetTypedSelector(CGF, Sel, std::string());
 }
 
 llvm::Value *CGObjCGNU::GetSelector(CodeGenFunction &CGF,
                                     const ObjCMethodDecl *Method) {
   std::string SelTypes = CGM.getContext().getObjCEncodingForMethodDecl(Method);
-  return GetSelector(CGF, Method->getSelector(), SelTypes);
+  return GetTypedSelector(CGF, Method->getSelector(), SelTypes);
 }
 
 llvm::Constant *CGObjCGNU::GetEHType(QualType T) {
   if (T->isObjCIdType() || T->isObjCQualifiedIdType()) {
     // With the old ABI, there was only one kind of catchall, which broke
     // foreign exceptions.  With the new ABI, we use __objc_id_typeinfo as
     // a pointer indicating object catchalls, and NULL to indicate real
     // catchalls