Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[libcxx] [test] Remove assertion that <bitset> includes <cstddef> and <stdexcept>.

Authored by BillyONeal on Aug 7 2018, 4:45 PM.



[template.bitset] says only that <string> and <iosfwd> are included by <bitset>, but libcxx tests are asserting that <cstddef> and <stdexcept> are also included.

Note that libcxx's nonstandard assertion of this is already handled by test/libcxx/utilities/template.bitset/includes.pass.cpp

Diff Detail

Event Timeline

BillyONeal created this revision.Aug 7 2018, 4:45 PM
EricWF accepted this revision.Aug 7 2018, 5:08 PM

This looks fine to me.

This revision is now accepted and ready to land.Aug 7 2018, 5:08 PM
Quuxplusone added inline comments.

grammar nit: comma

BillyONeal added inline comments.Aug 7 2018, 5:17 PM

NP: Oxford Comma by Vampire Weekend

BillyONeal updated this revision to Diff 159632.Aug 7 2018, 5:43 PM

Remove comma.

BillyONeal closed this revision.Aug 7 2018, 5:44 PM
BillyONeal marked 2 inline comments as done.

Committed r339212