Unlike the win32 abi, the win64 abi doesn't have leading underscores in symbols, so stripping them from the nm output causes symbols without leading underscores to not appear at all and symbols with leading underscores to be missing said underscore, causing an error when attempting to compile the shared library. This fixes that.
Details
Details
- Reviewers
- None
Diff Detail
Diff Detail
Event Timeline
tools/llvm-shlib/Makefile | ||
---|---|---|
100 | Can we instead of full copy & paste conditionalize the pattern only? |
tools/llvm-shlib/Makefile | ||
---|---|---|
100 | Sure, any thoughts on how to do that? You can't really put the ifeq inside the command, and using string processing to assemble the command seemed worse to me than this. |
Comment Actions
Have you forgot to attach the updated patch? I do not see that something was changed since the original submission.
tools/llvm-shlib/Makefile | ||
---|---|---|
100 | Put it outside the command into a variable? |
Can we instead of full copy & paste conditionalize the pattern only?