This is an archive of the discontinued LLVM Phabricator instance.

[Tablegen] In TargetSchedule.td: Remove unused argument `pfmCounters` from ProcResourceUnits.
ClosedPublic

Authored by andreadb on Aug 6 2018, 6:48 AM.

Details

Summary

I am pretty sure that this is a no functional change.

PFM counters don't need to be passed in input to the definition of ProcResourceUnits.
class PfmIssueCounter (r329675) is used to map resources to PFM counter(s).

I verified that there is no difference in the code auto-generated by the subtarget emitter.

@gchatelet is this okay to commit?

Thanks in advance
-Andrea

Diff Detail

Repository
rL LLVM

Event Timeline

andreadb created this revision.Aug 6 2018, 6:48 AM
gchatelet accepted this revision.EditedAug 6 2018, 11:47 PM

Yep LGTM. Thanks!

This revision is now accepted and ready to land.Aug 6 2018, 11:47 PM
This revision was automatically updated to reflect the committed changes.