This is an archive of the discontinued LLVM Phabricator instance.

Remove duplicated code in CommandObjectQuit
ClosedPublic

Authored by teemperor on Aug 5 2018, 3:49 PM.

Reviewers

Commits

Summary

We already have the same check directly before, so this code can never be
reached (as seen in the test coverage).

Sure.

This revision is now accepted and ready to land.Aug 5 2018, 4:52 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lldb/

trunk/

source/

Commands/

7 lines

Show First 20 Lines • Show All 80 Lines • ▼ Show 20 Lines	bool CommandObjectQuit::DoExecute(Args &command, CommandReturnObject &result) {

if (command.GetArgumentCount() > 1) {		if (command.GetArgumentCount() > 1) {
result.AppendError("Too many arguments for 'quit'. Only an optional exit "		result.AppendError("Too many arguments for 'quit'. Only an optional exit "
"code is allowed");		"code is allowed");
result.SetStatus(eReturnStatusFailed);		result.SetStatus(eReturnStatusFailed);
return false;		return false;
}		}

if (command.GetArgumentCount() > 1) {
result.AppendError("Too many arguments for 'quit'. Only an optional exit "
"code is allowed");
result.SetStatus(eReturnStatusFailed);
return false;
}

// We parse the exit code argument if there is one.		// We parse the exit code argument if there is one.
if (command.GetArgumentCount() == 1) {		if (command.GetArgumentCount() == 1) {
llvm::StringRef arg = command.GetArgumentAtIndex(0);		llvm::StringRef arg = command.GetArgumentAtIndex(0);
int exit_code;		int exit_code;
if (arg.getAsInteger(/autodetect radix/ 0, exit_code)) {		if (arg.getAsInteger(/autodetect radix/ 0, exit_code)) {
lldb_private::StreamString s;		lldb_private::StreamString s;
std::string arg_str = arg.str();		std::string arg_str = arg.str();
s.Printf("Couldn't parse '%s' as integer for exit code.", arg_str.data());		s.Printf("Couldn't parse '%s' as integer for exit code.", arg_str.data());
Show All 18 Lines