This is an archive of the discontinued LLVM Phabricator instance.

[OpenMP][libomptarget] Simplify warp master selection for data sharing
ClosedPublic

Authored by gtbercea on Aug 2 2018, 7:57 AM.

Details

Summary

There is currently no supported situation where the warp master is not the first thread in the warp.

This also avoids the device execution from hanging on Volta GPUs when ballot_sync is called by a number of threads that is less that the size of a warp.

Diff Detail

Repository
rOMP OpenMP

Event Timeline

gtbercea created this revision.Aug 2 2018, 7:57 AM
gtbercea retitled this revision from [OpenMP] Simplify warp master selection for data sharing to [OpenMP][libomptarget] Simplify warp master selection for data sharing.Aug 2 2018, 7:58 AM
grokos accepted this revision.Sep 12 2018, 6:21 AM

I completely missed this one. The proposed change makes sense.

This revision is now accepted and ready to land.Sep 12 2018, 6:21 AM
This revision was automatically updated to reflect the committed changes.