This is an archive of the discontinued LLVM Phabricator instance.

Differential D50026

Remove Stream::UnitTest
ClosedPublic

Authored by teemperor on Jul 30 2018, 3:57 PM.

Details

Reviewers
davide
Commits
rG56bf356a4b7f: Remove Stream::UnitTest
rLLDB338345: Remove Stream::UnitTest
rL338345: Remove Stream::UnitTest
Summary

No one is using this method, and it also doesn't really make a lot of sense to have it around.

Diff Detail

Repository
rL LLVM

Event Timeline

teemperor created this revision.Jul 30 2018, 3:57 PM
davide accepted this revision.Jul 30 2018, 5:37 PM
davide added a subscriber: davide.

LGTM.

This revision is now accepted and ready to land.Jul 30 2018, 5:37 PM
Closed by commit rL338345: Remove Stream::UnitTest (authored by teemperor). · Explain WhyJul 30 2018, 6:22 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptJul 30 2018, 6:22 PM

Revision Contents

PathSize
lldb/
trunk/
include/
lldb/
Utility/
2 lines
source/
Utility/
45 lines

Diff 158151

lldb/trunk/include/lldb/Utility/Stream.h

Show First 20 Lines • Show All 518 Lines • ▼ Show 20 Linespublic:
/// @param[in] uval /// @param[in] uval
/// A uint64_t value that was extracted as a ULEB128 value. /// A uint64_t value that was extracted as a ULEB128 value.
/// ///
/// @param[in] format /// @param[in] format
/// The optional printf format that can be overridden. /// The optional printf format that can be overridden.
//------------------------------------------------------------------ //------------------------------------------------------------------
size_t PutULEB128(uint64_t uval); size_t PutULEB128(uint64_t uval);
static void UnitTest(Stream *s);
protected: protected:
//------------------------------------------------------------------ //------------------------------------------------------------------
// Member variables // Member variables
//------------------------------------------------------------------ //------------------------------------------------------------------
Flags m_flags; ///< Dump flags. Flags m_flags; ///< Dump flags.
uint32_t m_addr_size; ///< Size of an address in bytes. uint32_t m_addr_size; ///< Size of an address in bytes.
lldb::ByteOrder lldb::ByteOrder
m_byte_order; ///< Byte order to use when encoding scalar types. m_byte_order; ///< Byte order to use when encoding scalar types.
int m_indent_level; ///< Indention level. int m_indent_level; ///< Indention level.
size_t _PutHex8(uint8_t uvalue, bool add_prefix); size_t _PutHex8(uint8_t uvalue, bool add_prefix);
}; };
} // namespace lldb_private } // namespace lldb_private
#endif // liblldb_Stream_h_ #endif // liblldb_Stream_h_

lldb/trunk/source/Utility/Stream.cpp

Show First 20 Lines • Show All 520 Lines • ▼ Show 20 Linessize_t Stream::PutCStringAsRawHex8(const char *s) {
do { do {
bytes_written += _PutHex8(*s, false); bytes_written += _PutHex8(*s, false);
++s; ++s;
} while (*s); } while (*s);
if (binary_is_set) if (binary_is_set)
m_flags.Set(eBinary); m_flags.Set(eBinary);
return bytes_written; return bytes_written;
} }
void Stream::UnitTest(Stream *s) {
s->PutHex8(0x12);
s->PutChar(' ');
s->PutHex16(0x3456, endian::InlHostByteOrder());
s->PutChar(' ');
s->PutHex16(0x3456, eByteOrderBig);
s->PutChar(' ');
s->PutHex16(0x3456, eByteOrderLittle);
s->PutChar(' ');
s->PutHex32(0x789abcde, endian::InlHostByteOrder());
s->PutChar(' ');
s->PutHex32(0x789abcde, eByteOrderBig);
s->PutChar(' ');
s->PutHex32(0x789abcde, eByteOrderLittle);
s->PutChar(' ');
s->PutHex64(0x1122334455667788ull, endian::InlHostByteOrder());
s->PutChar(' ');
s->PutHex64(0x1122334455667788ull, eByteOrderBig);
s->PutChar(' ');
s->PutHex64(0x1122334455667788ull, eByteOrderLittle);
const char *hola = "Hello World!!!";
s->PutChar(' ');
s->PutCString(hola);
s->PutChar(' ');
s->Write(hola, 5);
s->PutChar(' ');
s->PutCStringAsRawHex8(hola);
s->PutChar(' ');
s->PutCStringAsRawHex8("01234");
s->PutChar(' ');
s->Printf("pid=%i", 12733);
s->PutChar(' ');
s->PrintfAsRawHex8("pid=%i", 12733);
s->PutChar('\n');
}