This is an archive of the discontinued LLVM Phabricator instance.

[Hexagon] Remove fp-contract=fast setting for at O3
ClosedPublic

Authored by bcahoon on Jul 30 2018, 11:48 AM.

Reviewers

Commits

Summary

Change Hexagon so that the setting for fp-contract is the default setting. This makes Hexagon consistent with all the other targets.

This revision is now accepted and ready to land.Aug 1 2018, 7:41 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

Driver/

ToolChains/

5 lines

test/

Driver/

2 lines

Show First 20 Lines • Show All 507 Lines • ▼ Show 20 Lines	unsigned HexagonToolChain::getOptimizationLevel(
if (S.getAsInteger(10, OptLevel))		if (S.getAsInteger(10, OptLevel))
return 0;		return 0;
return OptLevel;		return OptLevel;
}		}

void HexagonToolChain::addClangTargetOptions(const ArgList &DriverArgs,		void HexagonToolChain::addClangTargetOptions(const ArgList &DriverArgs,
ArgStringList &CC1Args,		ArgStringList &CC1Args,
Action::OffloadKind) const {		Action::OffloadKind) const {
if (!DriverArgs.hasArg(options::OPT_ffp_contract)) {
unsigned OptLevel = getOptimizationLevel(DriverArgs);
if (OptLevel >= 3)
CC1Args.push_back("-ffp-contract=fast");
}
if (DriverArgs.hasArg(options::OPT_ffixed_r19)) {		if (DriverArgs.hasArg(options::OPT_ffixed_r19)) {
CC1Args.push_back("-target-feature");		CC1Args.push_back("-target-feature");
CC1Args.push_back("+reserved-r19");		CC1Args.push_back("+reserved-r19");
}		}
if (isAutoHVXEnabled(DriverArgs)) {		if (isAutoHVXEnabled(DriverArgs)) {
CC1Args.push_back("-mllvm");		CC1Args.push_back("-mllvm");
CC1Args.push_back("-hexagon-autohvx");		CC1Args.push_back("-hexagon-autohvx");
}		}
▲ Show 20 Lines • Show All 62 Lines • Show Last 20 Lines

	Show First 20 Lines • Show All 104 Lines • ▼ Show 20 Lines
	// CHECK025: "-cc1" {{.*}} "-target-cpu" "hexagonv65"			// CHECK025: "-cc1" {{.*}} "-target-cpu" "hexagonv65"
	// CHECK025: hexagon-link{{.*}}/Inputs/hexagon_tree/Tools/bin/../target/hexagon/lib/v65/crt0			// CHECK025: hexagon-link{{.*}}/Inputs/hexagon_tree/Tools/bin/../target/hexagon/lib/v65/crt0

	// RUN: %clang -### -target hexagon-unknown-elf \			// RUN: %clang -### -target hexagon-unknown-elf \
	// RUN: -ccc-install-dir %S/Inputs/hexagon_tree/Tools/bin \			// RUN: -ccc-install-dir %S/Inputs/hexagon_tree/Tools/bin \
	// RUN: -O3 \			// RUN: -O3 \
	// RUN: %s 2>&1 \			// RUN: %s 2>&1 \
	// RUN: \| FileCheck -check-prefix=CHECK026 %s			// RUN: \| FileCheck -check-prefix=CHECK026 %s
	// CHECK026: "-ffp-contract=fast"			// CHECK026-NOT: "-ffp-contract=fast"
	// CHECK026: hexagon-link			// CHECK026: hexagon-link

	// RUN: %clang -### -target hexagon-unknown-elf \			// RUN: %clang -### -target hexagon-unknown-elf \
	// RUN: -ccc-install-dir %S/Inputs/hexagon_tree/Tools/bin \			// RUN: -ccc-install-dir %S/Inputs/hexagon_tree/Tools/bin \
	// RUN: -O3 -ffp-contract=off \			// RUN: -O3 -ffp-contract=off \
	// RUN: %s 2>&1 \			// RUN: %s 2>&1 \
	// RUN: \| FileCheck -check-prefix=CHECK027 %s			// RUN: \| FileCheck -check-prefix=CHECK027 %s
	// CHECK027-NOT: "-ffp-contract=fast"			// CHECK027-NOT: "-ffp-contract=fast"
	▲ Show 20 Lines • Show All 404 Lines • Show Last 20 Lines