This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Make <experimental/filesystem> compile with gcc 4.8.5
ClosedPublic

Authored by vitaut on Jul 25 2018, 11:44 AM.

Details

Reviewers
EricWF
Summary

This fixes an error when compiling <experimental/filesystem> with gcc 4.8.5:

.../libcxx/src/experimental/filesystem/filesystem_common.h:137:34:
error: redeclaration ‘T
std::experimental::filesystem::v1::detail::{anonymous}::error_value() [with T =
bool]’ d
iffers in ‘constexpr’
 constexpr bool error_value<bool>() {
                                  ^
.../libcxx/src/experimental/filesystem/filesystem_common.h:133:3:
error: from previous declaration ‘T
std::experimental::filesystem::v1::detail::{anonymous}::error_value() [with T
 = bool]’
 T error_value();
   ^

Event Timeline

vitaut created this revision.Jul 25 2018, 11:44 AM
EricWF accepted this revision.Jul 25 2018, 1:35 PM

Urg. That's an old compiler. But this looks OK to me.

This revision is now accepted and ready to land.Jul 25 2018, 1:35 PM

@EricWF could you or someone else commit this as I don't have commit access? Thanks.

EricWF closed this revision.Jul 25 2018, 2:02 PM

r337962.

Thanks.