This is an archive of the discontinued LLVM Phabricator instance.

Differential D49538

Add -pthread to LDFLAGS
ClosedPublic

Authored by abeserminji on Jul 19 2018, 4:21 AM.

Details

Reviewers
petarj
MatzeB
Commits
rOLDT338515: Make Misc-C++-EH test to compiple with -static
rL338515: Make Misc-C++-EH test to compiple with -static
Summary

This test fails when compiling with -static option. Adding this flag resolves the linker error.

Diff Detail

Repository
rL LLVM

Event Timeline

abeserminji created this revision.Jul 19 2018, 4:21 AM
mstojanovic added a subscriber: mstojanovic.Jul 19 2018, 5:52 AM
MatzeB accepted this revision.Jul 20 2018, 12:43 PM

Please use -pthread instead of -lpthread, otherwise LGTM.

This revision is now accepted and ready to land.Jul 20 2018, 12:43 PM
abeserminji updated this revision to Diff 158485.Aug 1 2018, 3:07 AM
abeserminji retitled this revision from Add -lpthread to LDFLAGS to Add -pthread to LDFLAGS.

Comments addressed.

Closed by commit rL338515: Make Misc-C++-EH test to compiple with -static (authored by abeserminji). · Explain WhyAug 1 2018, 4:15 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test-suite/
trunk/
SingleSource/
Benchmarks/
Misc-C++-EH/
2 lines

Diff 158496

test-suite/trunk/SingleSource/Benchmarks/Misc-C++-EH/Makefile

LEVEL = ../../.. LEVEL = ../../..
LDFLAGS += -lm -lstdc++ LDFLAGS += -lm -lstdc++ -pthread
LIBS = -lstdc++ LIBS = -lstdc++
REQUIRES_EH_SUPPORT = 1 REQUIRES_EH_SUPPORT = 1
include $(LEVEL)/SingleSource/Makefile.singlesrc include $(LEVEL)/SingleSource/Makefile.singlesrc