[MachineOutliner] Check the last instruction from the sequence when updating liveness

[thegameg]

Summary

The MachineOutliner was doing an std::for_each from the call (inserted before the outlined sequence) to the iterator at the end of the sequence.

std::for_each needs the iterator past the end, so the last instruction was not taken into account when propagating the liveness information.

This fixes the machine verifier issue in machine-outliner-disubprogram.ll.

[paquette]

LGTM, thanks for catching that!

llvm/trunk/lib/CodeGen/MachineOutliner.cpp

if (MBB.getParent()->getProperties().hasProperty(
                                           true /* isImp = true */));
         }
       };
 
       // Copy over the defs in the outlined range.
       // First inst in outlined range <-- Anything that's defined in this
       // ...                           .. range has to be added as an implicit
       // Last inst in outlined range  <-- def to the call instruction.
-      std::for_each(CallInst, EndIt, CopyDefs);
+      std::for_each(CallInst, std::next(EndIt), CopyDefs);
     }
 
     // Erase from the point after where the call was inserted up to, and
     // including, the final instruction in the sequence.
     // Erase needs one past the end, so we need std::next there too.
     MBB.erase(std::next(StartIt), std::next(EndIt));
     OutlinedSomething = true;
 

llvm/trunk/test/CodeGen/X86/machine-outliner-disubprogram.ll

 ; Ensure that we can correctly emit a compile unit for outlined functions and
 ; that we correctly emit DISubprograms for those functions.
 ; Also make sure that the DISubprograms reference the generated unit.
 ; make sure that if there are two outlined functions in the program, 
-; RUN: llc %s -enable-machine-outliner -mtriple=x86_64-apple-darwin -o /dev/null -print-after=machine-outliner
+; RUN: llc %s -verify-machineinstrs -enable-machine-outliner -mtriple=x86_64-apple-darwin -o /dev/null -print-after=machine-outliner
 define void @f6() #0 !dbg !8 {
 entry:
   %dog = alloca i32, align 4
   %cat = alloca i32, align 4
   %pangolin = alloca i32, align 4
   call void @llvm.dbg.declare(metadata i32* %dog, metadata !11, metadata !DIExpression()), !dbg !13
   store i32 16, i32* %dog, align 4, !dbg !13
   call void @llvm.dbg.declare(metadata i32* %cat, metadata !14, metadata !DIExpression()), !dbg !15