This is an archive of the discontinued LLVM Phabricator instance.

Differential D49191

[DebugInfo][X86] Add start-after flags to MIR tests
ClosedPublic

Authored by thegameg on Jul 11 2018, 8:33 AM.

Details

Reviewers
aprantl
MatzeB
JDevlieghere
Commits
rG8b2ab91a5d03: [DebugInfo][X86] Add start-after flags to MIR tests
rL336907: [DebugInfo][X86] Add start-after flags to MIR tests
Summary

These tests would fail with -verify-machineinstrs because the MI generated from the IR would be merged with the one already in the MIR files, and we get the following error:

*** Bad machine code: Function has NoVRegs property but there are VReg operands ***
- function:    f

Diff Detail

Repository
rL LLVM

Event Timeline

thegameg created this revision.Jul 11 2018, 8:33 AM
Herald added subscribers: JDevlieghere, eraman. · View Herald TranscriptJul 11 2018, 8:33 AM
thegameg added a reviewer: JDevlieghere.Jul 11 2018, 8:37 AM
JDevlieghere accepted this revision.Jul 11 2018, 8:38 AM

LGTM, Thanks!

This revision is now accepted and ready to land.Jul 11 2018, 8:38 AM
Closed by commit rL336907: [DebugInfo][X86] Add start-after flags to MIR tests (authored by thegameg). · Explain WhyJul 12 2018, 7:41 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
test/
CodeGen/
MIR/
X86/
2 lines
DebugInfo/
MIR/
X86/
2 lines
4 lines

Diff 155173

llvm/trunk/test/CodeGen/MIR/X86/diexpr-win32.mir

# RUN: llc -filetype=obj -O0 %s -o - | llvm-readobj -codeview | FileCheck %s # RUN: llc -start-after=prologepilog -filetype=obj -O0 %s -o - | llvm-readobj -codeview | FileCheck %s
# #
# (DW_OP_plus_uconst 12) # (DW_OP_plus_uconst 12)
# CHECK: LocalSym { # CHECK: LocalSym {
# CHECK-NEXT: Kind: S_LOCAL (0x113E) # CHECK-NEXT: Kind: S_LOCAL (0x113E)
# CHECK-NEXT: Type: string* (0x # CHECK-NEXT: Type: string* (0x
# CHECK-NEXT: Flags [ (0x0) # CHECK-NEXT: Flags [ (0x0)
# CHECK-NEXT: ] # CHECK-NEXT: ]
# CHECK-NEXT: VarName: Str # CHECK-NEXT: VarName: Str
▲ Show 20 Lines • Show All 244 Lines • Show Last 20 Lines

llvm/trunk/test/DebugInfo/MIR/X86/bit-piece-dh.mir

# RUN: llc -filetype=obj -o - %s | llvm-dwarfdump -v --debug-info - | FileCheck %s # RUN: llc -verify-machineinstrs -start-after=prologepilog -filetype=obj -o - %s | llvm-dwarfdump -v --debug-info - | FileCheck %s
# CHECK: .debug_info contents: # CHECK: .debug_info contents:
# CHECK: DW_TAG_variable # CHECK: DW_TAG_variable
# CHECK-NEXT: DW_AT_location {{.*}} (DW_OP_reg1 RDX, DW_OP_bit_piece 0x8 0x8) # CHECK-NEXT: DW_AT_location {{.*}} (DW_OP_reg1 RDX, DW_OP_bit_piece 0x8 0x8)
# CHECK-NEXT: DW_AT_name {{.*}}"dh" # CHECK-NEXT: DW_AT_name {{.*}}"dh"
--- | --- |
; Manually created after: ; Manually created after:
; char f(int i) { ; char f(int i) {
; char dh = i>>8; ; char dh = i>>8;
▲ Show 20 Lines • Show All 88 Lines • Show Last 20 Lines

llvm/trunk/test/DebugInfo/MIR/X86/empty-inline.mir

# RUN: llc -filetype=obj -o - %s | llvm-dwarfdump -a - | FileCheck %s # RUN: llc -verify-machineinstrs -start-after=virtregrewriter -filetype=obj -o - %s | llvm-dwarfdump -a - | FileCheck %s
# #
# This testcase has an implicit def pseudo-iunstruction with a debug location. # This testcase has an implicit def pseudo-instruction with a debug location.
# #
# CHECK: .debug_info contents: # CHECK: .debug_info contents:
# CHECK: DW_TAG_subprogram # CHECK: DW_TAG_subprogram
# CHECK: DW_AT_low_pc (0x0000000000000000) # CHECK: DW_AT_low_pc (0x0000000000000000)
# CHECK-NOT: DW_TAG # CHECK-NOT: DW_TAG
# CHECK: DW_AT_specification {{.*}} "_ZN1C5m_fn3Ev" # CHECK: DW_AT_specification {{.*}} "_ZN1C5m_fn3Ev"
# CHECK-NOT: DW_TAG # CHECK-NOT: DW_TAG
# Here should not be an inlined subroutine with 0 length. # Here should not be an inlined subroutine with 0 length.
▲ Show 20 Lines • Show All 110 Lines • Show Last 20 Lines