This is an archive of the discontinued LLVM Phabricator instance.

[dsymutil] Make the CachedBinaryHolder the default.
ClosedPublic

Authored by JDevlieghere on Jun 29 2018, 6:28 AM.

Details

Summary

Replaces all uses of the old binary holder with its cached variant.

Diff Detail

Event Timeline

friss added inline comments.Jun 29 2018, 8:55 AM
llvm/tools/dsymutil/BinaryHolder.h
100

Why does this have to change in this patch? This looks like it's addressing a lifetime issue, but I'm not sure which one (and wouldn't it be needed in D48501?)

JDevlieghere marked an inline comment as done.Jun 29 2018, 9:13 AM
JDevlieghere added inline comments.
llvm/tools/dsymutil/BinaryHolder.h
100

Correct. I'll move into the first patch.

JDevlieghere marked an inline comment as done.
  • Move lifetime issue into parent patch.
friss accepted this revision.Jun 29 2018, 9:28 AM

LGTM

This revision is now accepted and ready to land.Jun 29 2018, 9:28 AM
This revision was automatically updated to reflect the committed changes.