Page MenuHomePhabricator

Fix path completion test case added in rL335905 on Windows
ClosedPublic

Authored by teemperor on Jun 28 2018, 2:46 PM.

Details

Summary

The test fails because we don't rewrite the slash behind foo to the OS specific
separator (as the completion API doesn't support this kind of rewriting). However,
we assume that this part of the string is rewritten in the test case, which broke
on Windows.

Diff Detail

Repository
rL LLVM

Event Timeline

teemperor created this revision.Jun 28 2018, 2:46 PM
stella.stamenova accepted this revision.Jun 28 2018, 2:49 PM
This revision is now accepted and ready to land.Jun 28 2018, 2:49 PM

@stella.stamenova I don't have access to a Windows machine. Would you mind testing if this fixes the issue?

teemperor updated this revision to Diff 153408.Jun 28 2018, 2:53 PM
  • Fixed an syntax error. Should work now.
stella.stamenova accepted this revision.Jun 28 2018, 3:33 PM

The test passes with the fix. Thanks!

This revision was automatically updated to reflect the committed changes.