This is an archive of the discontinued LLVM Phabricator instance.

Respect CMAKE_SYSROOT and don't search out libxml2 if it is set.
AbandonedPublic

Authored by srhines on Jun 21 2018, 3:00 PM.

Details

Reviewers
ruiu
Summary

If we ignore CMAKE_SYSROOT here, we end up always using the host
information for libxml2, when it is not appropriate. This makes builds
less hermetic than they should ideally be.

Diff Detail

Event Timeline

srhines created this revision.Jun 21 2018, 3:00 PM
srhines abandoned this revision.Jul 6 2018, 8:58 PM

Removed this in favor of the suggestions in https://reviews.llvm.org/D48459. Setting the CMAKE_FIND_ROOT_PATH_MODE* variables does make this properly hermetic.