This is an archive of the discontinued LLVM Phabricator instance.

Differential D48423

[liblang] Remove DOS line endings in libclang.exports
ClosedPublic

Authored by ro on Jun 21 2018, 5:33 AM.

Details

Reviewers
rsmith
yvvan
Commits
rG4bd5c4760127: [liblang] Remove DOS line endings in libclang.exports
rL335234: [liblang] Remove DOS line endings in libclang.exports
rC335234: [liblang] Remove DOS line endings in libclang.exports
Summary

libclang.so fails to link on Solaris:

Undefined first referenced
symbol in file
clang_getCompletionFixIt /var/gcc/llvm/obj/local/tools/clang/tools/libclang/libclang.exports
clang_getTokenLocation /var/gcc/llvm/obj/local/tools/clang/tools/libclang/libclang.exports
clang_getToken /var/gcc/llvm/obj/local/tools/clang/tools/libclang/libclang.exports
clang_getTemplateCursorKind /var/gcc/llvm/obj/local/tools/clang/tools/libclang/libclang.exports
clang_getTUResourceUsageName /var/gcc/llvm/obj/local/tools/clang/tools/libclang/libclang.exports
clang_getCompletionChunkKind /var/gcc/llvm/obj/local/tools/clang/tools/libclang/libclang.exports
clang_getCompletionChunkText /var/gcc/llvm/obj/local/tools/clang/tools/libclang/libclang.exports
clang_getSpellingLocation /var/gcc/llvm/obj/local/tools/clang/tools/libclang/libclang.exports
clang_getCompletionParent /var/gcc/llvm/obj/local/tools/clang/tools/libclang/libclang.exports
clang_getCompletionChunkCompletionString /var/gcc/llvm/obj/local/tools/clang/tools/libclang/libclang.exports
clang_getCompletionPriority /var/gcc/llvm/obj/local/tools/clang/tools/libclang/libclang.exports
clang_getCompletionNumFixIts /var/gcc/llvm/obj/local/tools/clang/tools/libclang/libclang.exports
clang_getTokenExtent /var/gcc/llvm/obj/local/tools/clang/tools/libclang/libclang.exports
clang_getCompletionNumAnnotations /var/gcc/llvm/obj/local/tools/clang/tools/libclang/libclang.exports
clang_getTokenKind /var/gcc/llvm/obj/local/tools/clang/tools/libclang/libclang.exports
ld: fatal: symbol referencing errors
collect2: error: ld returned 1 exit status
make[2]: *** [tools/clang/tools/libclang/CMakeFiles/libclang.dir/build.make:651: lib/libclang.so.7] Error 1

It turns out that this is caused by https://reviews.llvm.org/D46862: it added a
couple of CRs (^M) to some lines. Solaris ld takes them to be part of the symbol
names, which of course are missing from the input objects. GNU ld handles this
just fine. Fixed by removing the CRs.

Bootstrapped on i386-pc-solaris2.11. I guess this is obvious.

Diff Detail

Repository
rC Clang

Event Timeline

ro created this revision.Jun 21 2018, 5:33 AM
Herald added a subscriber: fedor.sergeev. · View Herald TranscriptJun 21 2018, 5:33 AM
yvvan accepted this revision.Jun 21 2018, 5:37 AM
yvvan added a subscriber: yvvan.

Thanks! I probably forgot to check line endings for this file before committing which I do for source files and headers...

This revision is now accepted and ready to land.Jun 21 2018, 5:37 AM
Closed by commit rC335234: [liblang] Remove DOS line endings in libclang.exports (authored by ro). · Explain WhyJun 21 2018, 6:45 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
tools/
libclang/
30 lines

Diff 152285

tools/libclang/libclang.exports

Show First 20 Lines • Show All 162 Lines • ▼ Show 20 Lines
clang_getCXXAccessSpecifier clang_getCXXAccessSpecifier
clang_getCanonicalCursor clang_getCanonicalCursor
clang_getCanonicalType clang_getCanonicalType
clang_getChildDiagnostics clang_getChildDiagnostics
clang_getClangVersion clang_getClangVersion
clang_getCompletionAnnotation clang_getCompletionAnnotation
clang_getCompletionAvailability clang_getCompletionAvailability
clang_getCompletionBriefComment clang_getCompletionBriefComment
clang_getCompletionChunkCompletionString clang_getCompletionChunkCompletionString
clang_getCompletionChunkKind clang_getCompletionChunkKind
clang_getCompletionChunkText clang_getCompletionChunkText
clang_getCompletionNumFixIts clang_getCompletionNumFixIts
clang_getCompletionFixIt clang_getCompletionFixIt
clang_getCompletionNumAnnotations clang_getCompletionNumAnnotations
clang_getCompletionParent clang_getCompletionParent
clang_getCompletionPriority clang_getCompletionPriority
clang_getCursor clang_getCursor
clang_getCursorAvailability clang_getCursorAvailability
clang_getCursorCompletionString clang_getCursorCompletionString
clang_getCursorDefinition clang_getCursorDefinition
clang_getCursorDisplayName clang_getCursorDisplayName
clang_getCursorPrintingPolicy clang_getCursorPrintingPolicy
clang_getCursorPrettyPrinted clang_getCursorPrettyPrinted
clang_getCursorExtent clang_getCursorExtent
▲ Show 20 Lines • Show All 67 Lines • ▼ Show 20 Lines
clang_getRange clang_getRange
clang_getRangeEnd clang_getRangeEnd
clang_getRangeStart clang_getRangeStart
clang_getRemappings clang_getRemappings
clang_getRemappingsFromFileList clang_getRemappingsFromFileList
clang_getResultType clang_getResultType
clang_getSkippedRanges clang_getSkippedRanges
clang_getSpecializedCursorTemplate clang_getSpecializedCursorTemplate
clang_getSpellingLocation clang_getSpellingLocation
clang_getTUResourceUsageName clang_getTUResourceUsageName
clang_getTemplateCursorKind clang_getTemplateCursorKind
clang_getToken clang_getToken
clang_getTokenExtent clang_getTokenExtent
clang_getTokenKind clang_getTokenKind
clang_getTokenLocation clang_getTokenLocation
clang_getTokenSpelling clang_getTokenSpelling
clang_getTranslationUnitCursor clang_getTranslationUnitCursor
clang_getTranslationUnitSpelling clang_getTranslationUnitSpelling
clang_getTranslationUnitTargetInfo clang_getTranslationUnitTargetInfo
clang_getTypeDeclaration clang_getTypeDeclaration
clang_getTypeKindSpelling clang_getTypeKindSpelling
clang_getTypeSpelling clang_getTypeSpelling
clang_getTypedefDeclUnderlyingType clang_getTypedefDeclUnderlyingType
▲ Show 20 Lines • Show All 94 Lines • Show Last 20 Lines