Page MenuHomePhabricator

[CodeGen} Avoid handling DBG_VALUE in LiveRegUnits::stepBackward
ClosedPublic

Authored by JesperAntonsson on Jun 21 2018, 4:42 AM.

Details

Summary

This patch prevents DBG_VALUE instructions from influencing LiveRegUnits::stepBackward(). It mirrors rL327862 / D43850 that made the same changes for LivePhysRegs.

What motivated this patch was a problem in an out-of-tree target where the PrologEpilogInserter does register scavenging and decides it has to spill the scavenged register that LiveRegUnits finds live as it has a DBG_VALUE use. Since it's out-of-tree and a bit involved, I don't have a testcase to present here.

Diff Detail

Repository
rL LLVM

Event Timeline

kparzysz accepted this revision.Jun 21 2018, 5:41 AM
This revision is now accepted and ready to land.Jun 21 2018, 5:41 AM

Thanks Krzysztof. I don't have commit rights yet, so I'd appreciate help to get this merged to trunk.

This revision was automatically updated to reflect the committed changes.