This is an archive of the discontinued LLVM Phabricator instance.

[X86] Rewrite the add/mul/or/and reduction intrinsics to make better use of other intrinsics and remove undef shuffle indices.
ClosedPublic

Authored by craig.topper on Jun 19 2018, 10:13 PM.

Diff Detail

Repository
rC Clang

Event Timeline

craig.topper created this revision.Jun 19 2018, 10:13 PM
RKSimon added inline comments.Jun 20 2018, 6:25 AM
test/CodeGen/avx512-reduceIntrin.c
1

We're using -O2 here but most codegen tests use -O0 - is that OK? It makes much more recognisable codegen, but I don't know what people expect from these intrinsics without optimization.

Change test to -O0

RKSimon accepted this revision.Jun 21 2018, 4:59 AM

LGTM (with suitable IR fast-isel tests in llvm)

This revision is now accepted and ready to land.Jun 21 2018, 4:59 AM
This revision was automatically updated to reflect the committed changes.