This is an archive of the discontinued LLVM Phabricator instance.

Refactor ClangUserExpression::Parse [NFC]
ClosedPublic

Authored by teemperor on Jun 19 2018, 3:41 PM.

Details

Summary

This patch splits out functionality from the Parse method into different methods.
This benefits the code completion work (which should reuse those methods) and makes the
code a bit more readable.

Note that this patch is as minimal as possible. Some of the code in the new methods definitely
needs more refactoring.

Diff Detail

Event Timeline

teemperor created this revision.Jun 19 2018, 3:41 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 10 2018, 3:17 PM
This revision was automatically updated to reflect the committed changes.