This is an archive of the discontinued LLVM Phabricator instance.

Differential D48327

[IPSCC] Drop ParamState lattice value when marking a value as force constant.
AbandonedPublic

Authored by fhahn on Jun 19 2018, 9:53 AM.

Details

Reviewers
davide
efriedma
Summary

ParamState lattice elements do not have support for forced constants,
so we have to drop any more precise information.

Fixes PR35723.

Diff Detail

Revision Contents

PathSize
lib/
Transforms/
Scalar/
3 lines
test/
Transforms/
SCCP/
24 lines

Diff 151935

lib/Transforms/Scalar/SCCP.cpp

Show First 20 Lines • Show All 422 Lines • ▼ Show 20 Lines void markConstant(Value *V, Constant *C) {
assert(!V->getType()->isStructTy() && "structs should use mergeInValue"); assert(!V->getType()->isStructTy() && "structs should use mergeInValue");
markConstant(ValueState[V], V, C); markConstant(ValueState[V], V, C);
} }
void markForcedConstant(Value *V, Constant *C) { void markForcedConstant(Value *V, Constant *C) {
assert(!V->getType()->isStructTy() && "structs should use mergeInValue"); assert(!V->getType()->isStructTy() && "structs should use mergeInValue");
LatticeVal &IV = ValueState[V]; LatticeVal &IV = ValueState[V];
IV.markForcedConstant(C); IV.markForcedConstant(C);
// ParamState lattice elements do not have support for forced constants,
// so we have to drop any more precise information.
ParamState.erase(V);
LLVM_DEBUG(dbgs() << "markForcedConstant: " << *C << ": " << *V << '\n'); LLVM_DEBUG(dbgs() << "markForcedConstant: " << *C << ": " << *V << '\n');
pushToWorkList(IV, V); pushToWorkList(IV, V);
} }
// markOverdefined - Make a value be marked as "overdefined". If the // markOverdefined - Make a value be marked as "overdefined". If the
// value is not already overdefined, add it to the overdefined instruction // value is not already overdefined, add it to the overdefined instruction
// work list so that the users of the instruction are updated later. // work list so that the users of the instruction are updated later.
void markOverdefined(LatticeVal &IV, Value *V) { void markOverdefined(LatticeVal &IV, Value *V) {
▲ Show 20 Lines • Show All 1,603 Lines • Show Last 20 Lines

test/Transforms/SCCP/ipsccp-paramstate-forcedconst.ll

  • This file was added.
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
; RUN: opt < %s -S -ipsccp | FileCheck %s
define void @main() {
; CHECK-LABEL: @main(
; CHECK-NEXT: [[CALL:%.*]] = call i1 @patatino(i1 undef)
; CHECK-NEXT: ret void
;
%call = call i1 @patatino(i1 undef)
ret void
}
define internal i1 @patatino(i1 %a) {
; CHECK-LABEL: @patatino(
; CHECK-NEXT: br label [[ONFALSE:%.*]]
; CHECK: onfalse:
; CHECK-NEXT: ret i1 undef
;
br i1 %a, label %ontrue, label %onfalse
ontrue:
ret i1 false
onfalse:
ret i1 false
}