This is an archive of the discontinued LLVM Phabricator instance.

Differential D48197

Avoid copying PrettyStackTrace messages an extra time on Apple platforms
ClosedPublic

Authored by jordan_rose on Jun 14 2018, 2:12 PM.

Details

Reviewers
dsanders
beanz
Summary

We were unnecessarily going from SmallString to std::string just to get a null-terminated C string. So just…don't do that. Crash slightly faster!

Diff Detail

Repository
rL LLVM

Event Timeline

jordan_rose created this revision.Jun 14 2018, 2:12 PM
dsanders accepted this revision.Jun 15 2018, 8:35 AM

LGTM :-)

This revision is now accepted and ready to land.Jun 15 2018, 8:35 AM
jordan_rose closed this revision.Jun 15 2018, 9:40 AM

Committed in rL334841.

Revision Contents

PathSize
lib/
Support/
4 lines

Diff 151424

lib/Support/PrettyStackTrace.cpp

Show First 20 Lines • Show All 112 Lines • ▼ Show 20 Lines#else
{ {
raw_svector_ostream Stream(TmpStr); raw_svector_ostream Stream(TmpStr);
PrintCurStackTrace(Stream); PrintCurStackTrace(Stream);
} }
if (!TmpStr.empty()) { if (!TmpStr.empty()) {
#ifdef HAVE_CRASHREPORTERCLIENT_H #ifdef HAVE_CRASHREPORTERCLIENT_H
// Cast to void to avoid warning. // Cast to void to avoid warning.
(void)CRSetCrashLogMessage(std::string(TmpStr.str()).c_str()); (void)CRSetCrashLogMessage(TmpStr.c_str());
#elif HAVE_CRASHREPORTER_INFO #elif HAVE_CRASHREPORTER_INFO
__crashreporter_info__ = strdup(std::string(TmpStr.str()).c_str()); __crashreporter_info__ = strdup(TmpStr.c_str());
#endif #endif
errs() << TmpStr.str(); errs() << TmpStr.str();
} }
#endif #endif
} }
// defined(HAVE_BACKTRACE) && ENABLE_BACKTRACES // defined(HAVE_BACKTRACE) && ENABLE_BACKTRACES
▲ Show 20 Lines • Show All 79 Lines • Show Last 20 Lines