Page MenuHomePhabricator

Avoid copying PrettyStackTrace messages an extra time on Apple platforms
ClosedPublic

Authored by jordan_rose on Jun 14 2018, 2:12 PM.

Details

Reviewers
dsanders
beanz
Summary

We were unnecessarily going from SmallString to std::string just to get a null-terminated C string. So just…don't do that. Crash slightly faster!

Diff Detail

Repository
rL LLVM

Event Timeline

jordan_rose created this revision.Jun 14 2018, 2:12 PM
dsanders accepted this revision.Jun 15 2018, 8:35 AM

LGTM :-)

This revision is now accepted and ready to land.Jun 15 2018, 8:35 AM
jordan_rose closed this revision.Jun 15 2018, 9:40 AM

Committed in rL334841.