This is an archive of the discontinued LLVM Phabricator instance.

[zorg] Add libc++ and libc++abi builders for Linux.
ClosedPublic

Authored by danalbert on Aug 4 2014, 4:56 PM.

Details

Reviewers
gribozavr
Summary

The existing libc++ builder is based on buildit/testit and assumes that
the platform has its own libc++abi, and as such it only works for OS X.
Add a new one that uses an in-tree build and cmake to be compatible with
the other platforms.

This builder will actually build and test both libc++ and libc++abi.
Since most platforms don't have either of these libraries installed and
depend on each other, we can't test them in isolation.

Diff Detail

Event Timeline

danalbert updated this revision to Diff 12182.Aug 4 2014, 4:56 PM
danalbert retitled this revision from to [zorg] Add libc++ and libc++abi builders for Linux..
danalbert updated this object.
danalbert edited the test plan for this revision. (Show Details)
danalbert added a reviewer: gribozavr.
danalbert added a subscriber: Unknown Object (MLST).
danalbert added inline comments.Aug 4 2014, 4:59 PM
zorg/buildbot/builders/LibcxxAndAbiBuilder.py
63

gribozavr: can I assume there's a relatively recent clang installed on your buildslave?

gribozavr added inline comments.Aug 4 2014, 11:23 PM
buildbot/osuosl/master/master.cfg
166–170

I don't think it depends on llvm and cfe, unless we are rebuilding a trunk clang every time.

zorg/buildbot/builders/LibcxxAndAbiBuilder.py
44

Please add an env var dictionary parameter like in other builder factories.

Then 'clang' and 'clangxx' parameters are not needed. When adding a builder one would just add CC='clang-3.5' or CC='clang-3.6'.

51–53

I am not sure if a non-fully qualified path will work. All other builder factories have a 'get_builddir' step.

Also, can we move 'build' one level up?

Do we need to rm -rf the previous build?

63

Of course, there is Clang 3.5 installed.

danalbert updated this revision to Diff 12199.Aug 5 2014, 8:55 AM
  • Address review comments
gribozavr added inline comments.Aug 5 2014, 8:59 AM
zorg/buildbot/builders/LibcxxAndAbiBuilder.py
67–69

I think this relative path is not correct now. You could use the build_path variable here.

danalbert updated this revision to Diff 12200.Aug 5 2014, 9:07 AM
  • Missed one relative path
gribozavr accepted this revision.Aug 5 2014, 9:37 AM
gribozavr edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Aug 5 2014, 9:37 AM
danalbert closed this revision.Aug 5 2014, 2:26 PM

Buildbot is up and running!