Page MenuHomePhabricator

[MS][ARM64]: Promote _setjmp to_setjmpex as there is no _setjmp in the ARM64 libvcruntime.lib
ClosedPublic

Authored by arm-chrjan01 on Jun 5 2018, 7:52 AM.

Diff Detail

Repository
rC Clang

Event Timeline

arm-chrjan01 created this revision.Jun 5 2018, 7:52 AM
rnk accepted this revision.Jun 5 2018, 11:09 AM

lgtm

I'm happy to refactor this after landing it as is, or you can do it if you like.

lib/CodeGen/CGBuiltin.cpp
3005–3006

We should probably refactor all this to use shared code.

This revision is now accepted and ready to land.Jun 5 2018, 11:09 AM

Thank you for reviewing Reid. Please could you commit the change for me as I don't have commit rights.
I had a go at refactoring it but the args to the x86 _setjmp at different, and combining the aarch64 and x64 versions didn't make the code more readable, IMHO. Happy for you to refactor after landing.

This revision was automatically updated to reflect the committed changes.
rnk added a comment.Jun 6 2018, 11:48 AM

Thanks for the patch!