This is an archive of the discontinued LLVM Phabricator instance.

Handle unexpected output in test output
ClosedPublic

Authored by emaste on Aug 4 2014, 6:33 AM.

Reviewers

gkistanova

Commits

Summary

LitTestCommand has a set of descriptions for test result codes, and ends up throwing an exception if an unexpected result is somehow reported.

We've been running the patch in this review on the FreeBSD-specific buildbot:
http://llvm-amd64.freebsd.your.org/b/builders/lldb-amd64-freebsd

emaste retitled this revision from to Handle unexpected output in test output.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added a reviewer: gkistanova.

emaste added a subscriber: Unknown Object (MLST).

Looks good to me
Thank you!

Closed by commit rL214767 (authored by @emaste).

Path

Size

zorg/

buildbot/

commands/

5 lines

Show First 20 Lines • Show All 134 Lines • ▼ Show 20 Lines	def evaluateCommand(self, cmd):
if self.logObserver.hadFailure():		if self.logObserver.hadFailure():
return FAILURE		return FAILURE

return SUCCESS		return SUCCESS

def describe(self, done=False):		def describe(self, done=False):
description = Test.describe(self, done)		description = Test.describe(self, done)
for name, count in self.logObserver.resultCounts.iteritems():		for name, count in self.logObserver.resultCounts.iteritems():
		if name in self.resultNames:
description.append('{0} {1}'.format(count, self.resultNames[name]))		description.append('{0} {1}'.format(count, self.resultNames[name]))
		else
		description.append('Unexpected test result output ' + name)
return description		return description

##		##

import unittest		import unittest

class StepProxy(object):		class StepProxy(object):
def __init__(self):		def __init__(self):
▲ Show 20 Lines • Show All 74 Lines • Show Last 20 Lines