Page MenuHomePhabricator

Remove SETCCE use from Lanai's backend
ClosedPublic

Authored by deadalnix on Jun 1 2018, 5:36 AM.

Details

Summary

This creates a small perf regression, but after talking with Jacques Pienaar, he was good with it to get things moving toward removng SETCCE.

Diff Detail

Repository
rL LLVM

Event Timeline

deadalnix created this revision.Jun 1 2018, 5:36 AM
jpienaar accepted this revision.Jun 1 2018, 7:27 AM

Looks good and as discussed the regression will be addressed by using carry.

The changes in LanaiAluCode.h seem unrelated, is that change needed for this too?

This revision is now accepted and ready to land.Jun 1 2018, 7:27 AM

The change in LanaiAluCode.h are indeed unrelated, let me remove them.

deadalnix updated this revision to Diff 149466.Jun 1 2018, 7:41 AM

Revert changes in LanaiAluCode.h

This revision was automatically updated to reflect the committed changes.