Page MenuHomePhabricator

[Unittests] Change linker flags of dynamic library tests
ClosedPublic

Authored by miyuki on May 29 2018, 3:51 AM.

Details

Summary

A recent change https://reviews.llvm.org/D46898 which had no intended
behavior change, actually modified the linker flags used when linking
the dynamic libraries used by the DynamicLibraryTests unit test. This
made the test fail in our testing environment which runs the tests
from an NFS share. Prior to D46898 the two libraries used by the test
were different (because the library name used to be embedded into the
binary), and after the change they became bit-to-bit identical. This
causes dlopen to return the same handle when these two libraries are
loaded from an NFS share, and the test expects two different handles.

This patch reverts the part of D46898 that is responsible for
changing the linker flags.

Diff Detail

Repository
rL LLVM

Event Timeline

miyuki created this revision.May 29 2018, 3:51 AM
miyuki retitled this revision from Unittests: Change linker flags of dynamic library tests to [Unittests] Change linker flags of dynamic library tests.May 29 2018, 3:58 AM

What platform does this occur on? Mac?

x86_64 linux

philip.pfaffe accepted this revision.Jun 6 2018, 3:08 AM

Interesting, I was under the impression that the relevant differences between MODULE and SHARED were only on Mac. In either case, this change LGTM.

This revision is now accepted and ready to land.Jun 6 2018, 3:08 AM
This revision was automatically updated to reflect the committed changes.