Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

[libcxx] [test] Remove nonportable locale assumption in basic.ios.members/narrow.pass.cpp

Authored by BillyONeal on May 25 2018, 2:51 PM.



I'm not sure if libcxx is asserting UTF-8 here; but on Windows the full char value is always passed through in its entirety, since the default codepage is something like Windows-1252. The replacement character is only used for non-chars there; and that should be a more portable test everywhere.

Diff Detail

Event Timeline

BillyONeal created this revision.May 25 2018, 2:51 PM

Committed r339213

(If there are changes requested I'll do them in a follow up commit)

Adding ldionne as suggested by Eric.

ldionne accepted this revision.Sep 22 2018, 5:07 PM

LGTM and has been committed -- you can close this.

This revision is now accepted and ready to land.Sep 22 2018, 5:07 PM
BillyONeal closed this revision.Oct 19 2018, 4:54 PM