This is an archive of the discontinued LLVM Phabricator instance.

Don't build tests for compiler-rt libs that aren't supported
AbandonedPublic

Authored by rnk on Jul 29 2014, 11:25 AM.

Details

Reviewers
samsonov
Summary

This silences lots of CMake warnings about adding dependencies on
non-existing targets.

Diff Detail

Event Timeline

rnk updated this revision to Diff 11989.Jul 29 2014, 11:25 AM
rnk retitled this revision from to Don't build tests for compiler-rt libs that aren't supported.
rnk updated this object.
rnk added a reviewer: samsonov.
rnk added a subscriber: Unknown Object (MLST).
samsonov edited edge metadata.Aug 6 2014, 3:50 PM

What CMake invocation produces such errors?

Anyway, this patch brings up a valid issue, but I think we should better determine which sanitizers are actually going to be built in the top-level CMakeLists.txt (or move this logic to some helper module). Let me know if you will update the patch, otherwise I'll make this change myself.

rnk added a comment.Aug 6 2014, 4:37 PM

On Windows, only ASan is built. However, we add the test suites for profile, tsan, and msan, all of which reference non-existing targets. This prevents us from doing that. If you want to hoist the logic for these decisions out of lib/CMakeLists, go for it, I'll close this.

Hopefully, this patch won't be needed after r215247.

rnk abandoned this revision.Aug 11 2014, 11:59 AM

Thanks! The warnings are fixed now.