Page MenuHomePhabricator

[NewGVN] Fix handling of assumes
ClosedPublic

Authored by nikic on May 16 2018, 12:45 PM.

Details

Summary

This patch fixes two bugs:

  • test1: Previously assume(a >= 5) concluded that a == 5. That's only valid for assume(a == 5)...
  • test2: If operands were swapped, additional users were added to the wrong cmp operand. This resulted in an "unsettled iteration" assertion failure.

Diff Detail

Repository
rL LLVM

Event Timeline

nikic created this revision.May 16 2018, 12:45 PM
This revision is now accepted and ready to land.May 16 2018, 12:52 PM
nox added a subscriber: nox.May 17 2018, 2:09 AM
nikic added a comment.May 21 2018, 8:11 AM

I don't have commit access, could someone please commit this patch?

fhahn added a subscriber: fhahn.May 21 2018, 8:22 AM

Can do, either later today or sometime tomorrow

This revision was automatically updated to reflect the committed changes.