This is an archive of the discontinued LLVM Phabricator instance.

[APFloat] Set losesInfo on no-op convert
ClosedPublic

Authored by svenvh on May 9 2018, 9:27 AM.

Details

Summary

losesInfo would be left unset when no conversion needs to be done. A
caller such as InstCombine's fitsInFPType would then branch on an
uninitialized value.

Caught using valgrind on an out-of-tree target.

Diff Detail

Repository
rL LLVM

Event Timeline

svenvh created this revision.May 9 2018, 9:27 AM
timshen accepted this revision.May 10 2018, 5:33 PM
This revision is now accepted and ready to land.May 10 2018, 5:33 PM
This revision was automatically updated to reflect the committed changes.