[llvm-objcopy] Add more tests for help messages

[alexander-shaposhnikov]

Summary

Slightly reorganize the tests + improve the coverage (for llvm-objcopy as well).
I'll wait for James to have a look at this.

Test plan: make check-all

[jhenderson]

LGTM with the suggested test update.

help-message.test

12

This and the other messages (apart from the USAGE ones) don't need to have unique prefixes for objcopy and strip. I'd rewrite them something like this:

# OBJCOPY-USAGE: USAGE: llvm-objcopy
# STRIP-USAGE:   USAGE: llvm-strip
# UNKNOWN-ARG: unknown argument '-abcabc'
# NO-INPUT-FILES: No input file specified

help-message.test

 # RUN: llvm-objcopy --help | FileCheck --check-prefix=CHECK-OBJCOPY %s
 # RUN: not llvm-objcopy 2>&1 | FileCheck --check-prefix=CHECK-OBJCOPY %s
+# RUN: not llvm-objcopy -abcabc 2>&1 | FileCheck --check-prefix=CHECK-OBJCOPY-UNKNOWN-ARGUMENT %s
+# RUN: not llvm-objcopy -strip-debug 2>&1 | FileCheck %s --check-prefix=CHECK-OBJCOPY-NO-INPUT-FILES
 
 # RUN: llvm-strip --help | FileCheck --check-prefix=CHECK-STRIP %s
 # RUN: not llvm-strip 2>&1 | FileCheck --check-prefix=CHECK-STRIP %s
+# RUN: not llvm-strip -abcabc 2>&1 | FileCheck --check-prefix=CHECK-STRIP-UNKNOWN-ARGUMENT %s
+# RUN: not llvm-strip -strip-debug 2>&1 | FileCheck %s --check-prefix=CHECK-STRIP-NO-INPUT-FILES
 
 # CHECK-OBJCOPY: USAGE: llvm-objcopy
+# CHECK-OBJCOPY-UNKNOWN-ARGUMENT: unknown argument '-abcabc'
+# CHECK-OBJCOPY-NO-INPUT-FILES: No input file specified
+
 # CHECK-STRIP:   USAGE: llvm-strip
+# CHECK-STRIP-UNKNOWN-ARGUMENT: unknown argument '-abcabc'
+# CHECK-STRIP-NO-INPUT-FILES: No input file specified

strip-debug.test

 # RUN: yaml2obj %s > %t
 # RUN: llvm-objcopy -strip-debug %t %t2
 # RUN: llvm-readobj -file-headers -sections -symbols %t2 | FileCheck %s
 
 # We run yaml2obj again rather than copy %t to avoid interfering 
 # with llvm-objcopy's test (which potentially could have corrupted/updated the binary).
 
 # RUN: yaml2obj %s > %t3
 # RUN: llvm-strip -strip-debug %t3
 # RUN: llvm-readobj -file-headers -sections -symbols %t3 | FileCheck %s
 # RUN: cmp %t2 %t3
 
-# RUN: not llvm-strip -strip-debug 2>&1 | FileCheck %s --check-prefix=NO-INPUT-FILES
-
 !ELF
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
   Type:            ET_REL
   Machine:         EM_X86_64
 Sections:
   - Name:            .debugfoo

 # CHECK-NEXT:     Value:
 # CHECK-NEXT:     Size:
 # CHECK-NEXT:     Binding: Global
 # CHECK-NEXT:     Type:
 # CHECK-NEXT:     Other:
 # CHECK-NEXT:     Section: .text
 # CHECK-NEXT:   }
 # CHECK-NEXT: ]
-
-# NO-INPUT-FILES: No input file specified