This is an archive of the discontinued LLVM Phabricator instance.

Differential D46136

[docs] Fix a typo in KaleidoscopeJIT tutorial
ClosedPublic

Authored by sas on Apr 26 2018, 10:55 AM.

Details

Reviewers
lhames
Commits
rG923d8ab1fa8c: [docs] Fix a typo in KaleidoscopeJIT tutorial
rL331794: [docs] Fix a typo in KaleidoscopeJIT tutorial
Summary

Just a missing end quote.

Diff Detail

Event Timeline

sas created this revision.Apr 26 2018, 10:55 AM
Harbormaster completed remote builds in B17455: Diff 144161.Apr 26 2018, 10:56 AM
This revision was not accepted when it landed; it landed in state Needs Review.May 8 2018, 11:47 AM
Closed by commit rL331794: [docs] Fix a typo in KaleidoscopeJIT tutorial (authored by sas). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
docs/
tutorial/
2 lines

Diff 144161

docs/tutorial/BuildingAJIT2.rst

Show First 20 Lines • Show All 218 Lines • ▼ Show 20 Lines
+------------------+-----------------------------------------------------------+ +------------------+-----------------------------------------------------------+
| Interface | Description | | Interface | Description |
+==================+===========================================================+ +==================+===========================================================+
| | Provides a handle that can be used to identify a module | | | Provides a handle that can be used to identify a module |
| ModuleHandleT | set when calling findSymbolIn, removeModule, or | | ModuleHandleT | set when calling findSymbolIn, removeModule, or |
| | emitAndFinalize. | | | emitAndFinalize. |
+------------------+-----------------------------------------------------------+ +------------------+-----------------------------------------------------------+
| | Takes a given set of Modules and makes them "available | | | Takes a given set of Modules and makes them "available |
| | for execution. This means that symbols in those modules | | | for execution". This means that symbols in those modules |
| | should be searchable via findSymbol and findSymbolIn, and | | | should be searchable via findSymbol and findSymbolIn, and |
| | the address of the symbols should be read/writable (for | | | the address of the symbols should be read/writable (for |
| | data symbols), or executable (for function symbols) after | | | data symbols), or executable (for function symbols) after |
| | JITSymbol::getAddress() is called. Note: This means that | | | JITSymbol::getAddress() is called. Note: This means that |
| addModule | addModule doesn't have to compile (or do any other | | addModule | addModule doesn't have to compile (or do any other |
| | work) up-front. It *can*, like IRCompileLayer, act | | | work) up-front. It *can*, like IRCompileLayer, act |
| | eagerly, but it can also simply record the module and | | | eagerly, but it can also simply record the module and |
| | take no further action until somebody calls | | | take no further action until somebody calls |
▲ Show 20 Lines • Show All 99 Lines • Show Last 20 Lines